Skip to content

Conversation

@bwikbs
Copy link
Member

@bwikbs bwikbs commented Aug 19, 2021

Signed-off-by: MuHong Byun mh.byun@samsung.com

@bbrto21
Copy link
Contributor

bbrto21 commented Aug 19, 2021

I've verified that this draft works fine with flutter-tizen/engine#169 on new test target.

@bwikbs bwikbs force-pushed the master branch 2 times, most recently from f0f26f5 to ae0259c Compare August 24, 2021 03:19
@bwikbs bwikbs force-pushed the master branch 2 times, most recently from dca9ed7 to e84241f Compare August 25, 2021 06:30
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Copy link
Member Author

bwikbs commented Aug 26, 2021

The increase of so size seems to be due to the toolchain issue.

@bwikbs
Copy link
Member Author

bwikbs commented Aug 26, 2021

This update enables webviews on the new target.

@bwikbs bwikbs marked this pull request as ready for review August 26, 2021 07:58
* Apply PlatformView, PlatformViewFactory APIs change

## 0.3.1
* Update lightweight web engine binary (ad0e77631f96180e19a11c3dc80b6b72c32bdffb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to mention the change made by #186 because it's included in this release (0.3.1).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👌

@swift-kim
Copy link
Member

Please update the usage section in README.

The webview_flutter and webview_flutter_tizen versions are expected to be 2.0.4 and 0.3.1 respectively.

bwikbs added 2 commits August 27, 2021 11:55
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bbrto21 bbrto21 merged commit 28540de into flutter-tizen:master Aug 30, 2021
@swift-kim
Copy link
Member

@bbrto21 Could you publish the package?

@bbrto21
Copy link
Contributor

bbrto21 commented Aug 30, 2021

@swift-kim Of course. I will publish it and notify you

@bbrto21
Copy link
Contributor

bbrto21 commented Aug 30, 2021

@swift-kim done~

seungsoo47 pushed a commit to seungsoo47/plugins that referenced this pull request Sep 10, 2021
…#184)

* [webview_flutter] Update lightweight web engine binary

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Add reviewer's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply reviewer's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants