Skip to content

Conversation

@seungsoo47
Copy link
Contributor

  • Remove analysis_options.yaml.
  • google_maps_flutter version up.
  • Fix crash issues and bugs.

Signed-off-by: leess seungsoo47.lee@samsung.com

@seungsoo47 seungsoo47 force-pushed the google_maps_220610 branch from d20922e to eeed629 Compare June 13, 2022 06:31
@seungsoo47 seungsoo47 changed the title [WIP][google_maps_flutter] Fix various bugs [google_maps_flutter] Fix various bugs Jun 13, 2022
* Remove analysis_options.yaml.
* google_maps_flutter version up.
* Fix crash issues and bugs.

Signed-off-by: leess <seungsoo47.lee@samsung.com>
Signed-off-by: Seungsoo Lee <seungsoo47.lee@samsung.com>
@seungsoo47 seungsoo47 force-pushed the google_maps_220610 branch from 596ec36 to 000ab46 Compare June 14, 2022 00:01
@seungsoo47
Copy link
Contributor Author

#389

@HakkyuKim
Copy link
Contributor

Since 0.1.2 is not released, all changes can be part of 0.1.2 and not 0.1.3. Do you have a reason to release two versions here?

@seungsoo47
Copy link
Contributor Author

Since 0.1.2 is not released, all changes can be part of 0.1.2 and not 0.1.3. Do you have a reason to release two versions here?

I thought that @bbrto21 already released 0.1.2 in the below patch.
https://github.com/flutter-tizen/plugins/pull/369/files
However, it just seems the version was not written in Changelog.md.

@HakkyuKim
Copy link
Contributor

Ah, I guess that was supposed to be released with CHANGELOG, since it wasn't, we can release 0.1.2 together with the current changes.

@seungsoo47
Copy link
Contributor Author

Ah, I guess that was supposed to be released with CHANGELOG, since it wasn't, we can release 0.1.2 together with the current changes.

Thank you very much :)

@bbrto21
Copy link
Contributor

bbrto21 commented Jun 23, 2022

  • google_maps_flutter version up.

Thanks Thank you for your hard work. but I have a question.
Shouldn't we update the example to the latest one instead of resolving issues of lint that exists in current example?
If not, do you have a plan to update the example with implementing additional feature of this plugin in the future?

@seungsoo47
Copy link
Contributor Author

  • google_maps_flutter version up.

Thanks Thank you for your hard work. but I have a question. Shouldn't we update the example to the latest one instead of resolving issues of lint that exists in current example? If not, do you have a plan to update the example with implementing additional feature of this plugin in the future?

The example of this pr is an already updated version. If there's something I'm missing, please let me know in detail. 😀

@bbrto21
Copy link
Contributor

bbrto21 commented Jun 24, 2022

I'm asking that if it's necessary to copy the latest original example to this plug-in.
I tried it based on this PR(I just replaced lib dir of the example.), and it seems to be no problem with the execution and behavior of the example, but some lint issues have been reported after the analyze.

@seungsoo47
Copy link
Contributor Author

I'm asking that if it's necessary to copy the latest original example to this plug-in. I tried it based on this PR(I just replaced lib dir of the example.), and it seems to be no problem with the execution and behavior of the example, but some lint issues have been reported after the analyze.

Thank you for your kind review. 😀 I am not sure that you remember what I said for this plugin. As you know, this plugin is based on webview plugin and uses google map web apis. However, the original examples are based on google map apis and the apis are different from web version apis a little bit. So, I removed some examples related to unsupported apis. By the way, if I miss some examples based on supported apis, please let me know it. ^^

@seungsoo47 seungsoo47 force-pushed the google_maps_220610 branch from 000ab46 to 360a054 Compare June 27, 2022 02:02
@swift-kim
Copy link
Member

Any updates? This package is the last package that depends on the analysis_options_legacy.yaml file. The file will be deleted after this PR is merged.

Signed-off-by: Seungsoo Lee <seungsoo47.lee@samsung.com>
@seungsoo47 seungsoo47 force-pushed the google_maps_220610 branch from 360a054 to 5bd319e Compare July 6, 2022 05:36
@seungsoo47
Copy link
Contributor Author

seungsoo47 commented Jul 6, 2022

Any updates? This package is the last package that depends on the analysis_options_legacy.yaml file. The file will be deleted after this PR is merged.

No more updates. Please merge this pr.

@bbrto21 bbrto21 merged commit 1c73363 into flutter-tizen:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants