Skip to content

Conversation

@swift-kim
Copy link
Member

@swift-kim swift-kim commented May 25, 2023

This reverts #455.

The extended classes generate compile errors on Flutter 3.10 because they use the StreamHandlerError constructor. The constructor takes std::unique_ptr&& instead of a plain pointer since Flutter 3.10.

src/messageport_tizen_plugin.cc:56:9: error: no matching constructor for initialization of 'FlStreamHandlerError' (aka 'StreamHandlerError<flutter::EncodableValue>')
        FlStreamHandlerError(error_code_, error_message_, error_details) {}
        ^                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/swift/Git/flutter-tizen/flutter/bin/cache/artifacts/engine/tizen-common/cpp_client_wrapper/include/flutter/event_stream_handler.h:23:3: note: candidate constructor not
viable: no known conversion from 'const flutter::EncodableValue *' to 'std::unique_ptr<EncodableValue>' for 3rd argument
  StreamHandlerError(const std::string error_code,
  ^

@swift-kim
Copy link
Member Author

@bbrto21 @JSUYA This is one of prerequisites for flutter-tizen/flutter-tizen#497. Please review ASAP.

Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
PS. Sorry for late review.

@swift-kim swift-kim merged commit 1bf59f7 into flutter-tizen:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants