Skip to content

Conversation

@JSUYA
Copy link
Member

@JSUYA JSUYA commented Oct 27, 2025

#916

This plugin controls windows and obtains geometry information. It only works when the RendererType is EGL.
(EvasGL has been removed.)

@JSUYA JSUYA marked this pull request as draft October 27, 2025 02:17
@JSUYA JSUYA force-pushed the tizen_window_manager branch from 17e2cc3 to ad13773 Compare October 27, 2025 06:51
@JSUYA JSUYA changed the title [WIP] Introduce tizen_window_manager plugin Introduce tizen_window_manager plugin Oct 27, 2025
@JSUYA JSUYA marked this pull request as ready for review October 27, 2025 08:01
@JSUYA JSUYA marked this pull request as draft October 27, 2025 08:02
@JSUYA JSUYA marked this pull request as ready for review October 27, 2025 08:07
Copy link
Contributor

@seungsoo47 seungsoo47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor issue

@@ -0,0 +1,25 @@
Copyright (c) 2021 Samsung Electronics Co., Ltd. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright (c) 2021 Samsung Electronics Co., Ltd. All rights reserved.
Copyright (c) 2025 Samsung Electronics Co., Ltd. All rights reserved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JSUYA
Copy link
Member Author

JSUYA commented Oct 29, 2025

}
}

FlutterDesktopPluginRegistrarRef registrar_ref_;
Copy link
Contributor

@xiaowei-guan xiaowei-guan Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove registrar_ref_, because the plugin just uses it one time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JSUYA JSUYA merged commit 886de5a into flutter-tizen:master Oct 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants