-
-
Notifications
You must be signed in to change notification settings - Fork 317
Reset signalling state when answer a call after receiving 180/183 with SDP. #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| //if (this._connection.signalingState == RTCSignalingState.RTCSignalingStateStable) | ||
| /*{ | ||
| if (this._connection.signalingState == | ||
| RTCSignalingState.RTCSignalingStateStable) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works if this line is changed to
RTCSignalingState.RTCSignalingStateHaveLocalOffer) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks wrong. If the status is not RTCSignalingStateHaveLocalOffer after receiving 180/183 with SDP, maybe we should check if the early media is properly connected.
|
Isn't the design already in JsSIP?
|
|
Yes, there are already designs in JsSIP, but the expected state is inconsistent. The explanation of If you have already received 180/183 with SDP, the status here should be "have-remote-pranswer" because pc has completed an offer/answer process |
|
I use this branch to test the call on FreeSwitch, answered after receiving the early media, it seems to work fine. |
|
It's a holiday here tomorrow, but I can arrange access to an asterisk system next week if that helps. |
|
@rlsutton1 If you can, please send the asterisk test account to my Github email to reproduce the error, but I have a week holiday and go online again on October 3. |
|
The expected state should be RTCSignalingStateStable because the SDP negotiation has been completed. The explanation of ==> it may also mean that negotiation is complete and a connection has been established. <== So I think this PR is correct, and when you test on Asterisk, the state is RTCSignalingState.RTCSignalingStateHaveLocalOffer, I guess your state is after the completion of CreateOffer and SetLocalDescription, but before receiving the 180/183 SDP, but I don't understand why I can't setRemoteDescription. |
|
I’ve been attempting to connect with FreeSWITCH using the provided example in this repo, but without success. Can anyone provide me with a working example for connecting with FreeSWITCH? I’ve even tried using code generated by ChatGPT, but it didn’t work. I’ve been stuck on this for days and would appreciate any help. |
I added state storage to flutter-webrtc.
flutter-webrtc/flutter-webrtc@396af85
Try to fix the error after receiving 180/183 with SDP.