Skip to content

Conversation

@makstheimba
Copy link

Fix for #185

@cloudwebrtc
Copy link
Member

Cool, Maybe we should move InfoEvent from internal events to the public?
https://github.com/flutter-webrtc/dart-sip-ua/blob/master/lib/src/event_manager/internal_events.dart#L74

like info_events.dart and provide InfoEvent listener where.
https://github.com/flutter-webrtc/dart-sip-ua/blob/master/lib/src/sip_ua_helper.dart#L182

@makstheimba
Copy link
Author

makstheimba commented Sep 16, 2021

@cloudwebrtc Do I understand correctly that in your comment you propose to add an ability to also listening for InfoEvents?

It may be a good suggestion. We didn't need it in our project and because of that I didn't thought about adding it 🤔

@cloudwebrtc
Copy link
Member

Okay,When someone needs this feature, I will create a new PR.

@cloudwebrtc cloudwebrtc merged commit 9f37077 into flutter-webrtc:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants