Subscribe support #269
Merged
Subscribe support #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This also closes #203 |
Collaborator
|
Awesome!!!!!! |
Collaborator
Author
|
The changed SDK version was an oversight. Forgot to change it back. |
cloudwebrtc
reviewed
Apr 9, 2022
cloudwebrtc
reviewed
Apr 9, 2022
Member
|
thanks, it looks good |
avanlent
added a commit
to sorenson-eng/dart-sip-ua
that referenced
this pull request
Apr 13, 2022
* Subscribe support (flutter-webrtc#269) * Implemented subscribe support like here versatica/JsSIP#711 * Fixed type Errors * Made events consistant * Chore: Began Subscriber rework * Feat: Implemented subscribe support * Changed subscriber id to be the call id * Added termination to subscribers * Moved back sdk version to 2.14.0 * Fixed unrealted bug in hangup * Made imports relative Co-authored-by: Perondas <Pperondas@gmail.com> Co-authored-by: Perondas <114622@fhwn.ac.at> * SIP OPTIONS support (flutter-webrtc#270) * Allow sending and responding to SIP OPTIONS messages * Add sendOptions and handle incoming OPTIONS * Check bool value with null check * Changes after running 'flutter format lib/ test/' * Fixed runtime error on final notify (flutter-webrtc#273) Co-authored-by: Perondas <114622@fhwn.ac.at> Co-authored-by: Perondas <47948606+Perondas@users.noreply.github.com> Co-authored-by: Perondas <Pperondas@gmail.com> Co-authored-by: Perondas <114622@fhwn.ac.at>
|
how can i use it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the subscribe support like in this PR on the JsSIP repo.
Differences are that I did not implement the Notifier class.