Skip to content

Fix event pr #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Fix event pr #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
127adc5
add converter from string to enum to enumhelper
rlsutton1 Oct 28, 2019
52cd848
remove Socket from Transport event, it was the wrong type and should …
rlsutton1 Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/src/enum_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,14 @@ class EnumHelper {
static String reCase(String value) {
return ReCase(value).titleCase;
}

static T getEnum<T>(String enumName, List<T> values) {
String cleanedName = reCase(enumName);
for (int i = 0; i < values.length; i++) {
if (cleanedName == getName(values[i])) {
return values[i];
}
}
throw Exception("$cleanedName doesn't exist in the list of enums $values");
}
}
11 changes: 4 additions & 7 deletions lib/src/sip_ua_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,22 +129,20 @@ class SIPUAHelper extends EventManager {
this._ua = UA(_settings);
this._ua.on(EventSocketConnecting(), (EventSocketConnecting event) {
logger.debug('connecting => ' + event.toString());
_notifyTransportStateListeners(TransportState(
TransportStateEnum.CONNECTING,
socket: event.socket));
_notifyTransportStateListeners(
TransportState(TransportStateEnum.CONNECTING));
});

this._ua.on(EventSocketConnected(), (EventSocketConnected event) {
logger.debug('connected => ' + event.toString());
_notifyTransportStateListeners(
TransportState(TransportStateEnum.CONNECTED, socket: event.socket));
TransportState(TransportStateEnum.CONNECTED));
});

this._ua.on(EventSocketDisconnected(), (EventSocketDisconnected event) {
logger.debug('disconnected => ' + (event.cause.toString()));
_notifyTransportStateListeners(TransportState(
TransportStateEnum.DISCONNECTED,
socket: event.socket,
cause: event.cause));
});

Expand Down Expand Up @@ -422,9 +420,8 @@ enum TransportStateEnum {

class TransportState {
TransportStateEnum state;
Socket socket;
ErrorCause cause;
TransportState(this.state, {this.socket = null, this.cause});
TransportState(this.state, {this.cause});
}

abstract class SipUaHelperListener {
Expand Down