-
-
Notifications
You must be signed in to change notification settings - Fork 317
Refactor sip method and some bug fixes #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sip method and some bug fixes #7
Conversation
|
There was an error when compiling.
|
|
Using a strong type instead of a var variable declaration is a very good idea, and later will gradually replace the var declaration with a real type. |
|
I've removed error, It should compile cleanly now |
|
@rlsutton1 I have merged the PR and regenerated the grammar parser. //TODO: Commented out because this seems to cause errors with Asterisk
//await this._connection.setRemoteDescription(answer);I temporarily removed the comments, I think the process here should be no problem, the error should be caused by other reasons. You can provide some device logs about asterisk calls to help locate the problem. |
OK, I'll try to provide some logs tomorrow. |
This pull request refactors the Sip Method from a String to an Enum and infers types where possible which should ease the long term maintenance of the project.
Included are a few bug fixes, namely