Skip to content

fix bug for FF. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix bug for FF. #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions lib/src/rtc_rtp_parameters_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,19 @@ class RTCRtpParametersWeb {
static RTCRtpParameters fromJsObject(Object object) {
return RTCRtpParameters(
transactionId: jsutil.getProperty(object, 'transactionId'),
rtcp: RTCRTCPParametersWeb.fromJsObject(
jsutil.getProperty(object, 'rtcp')),
rtcp: jsutil.hasProperty(object, 'transactionId')
? RTCRTCPParametersWeb.fromJsObject(
jsutil.getProperty(object, 'rtcp'))
: null,
headerExtensions: headerExtensionsFromJsObject(object),
encodings: encodingsFromJsObject(object),
codecs: codecsFromJsObject(object));
}

static List<RTCHeaderExtension> headerExtensionsFromJsObject(Object object) {
var headerExtensions = jsutil.getProperty(object, 'headerExtensions');
var headerExtensions = jsutil.hasProperty(object, 'headerExtensions')
? jsutil.getProperty(object, 'headerExtensions')
: [];
var list = <RTCHeaderExtension>[];
headerExtensions.forEach((e) {
list.add(RTCHeaderExtensionWeb.fromJsObject(e));
Expand All @@ -22,7 +26,9 @@ class RTCRtpParametersWeb {
}

static List<RTCRtpEncoding> encodingsFromJsObject(Object object) {
var encodings = jsutil.getProperty(object, 'encodings');
var encodings = jsutil.hasProperty(object, 'encodings')
? jsutil.getProperty(object, 'encodings')
: [];
var list = <RTCRtpEncoding>[];
encodings.forEach((e) {
list.add(RTCRtpEncodingWeb.fromJsObject(e));
Expand All @@ -31,7 +37,9 @@ class RTCRtpParametersWeb {
}

static List<RTCRTPCodec> codecsFromJsObject(Object object) {
var encodings = jsutil.getProperty(object, 'codecs');
var encodings = jsutil.hasProperty(object, 'codecs')
? jsutil.getProperty(object, 'codecs')
: [];
var list = <RTCRTPCodec>[];
encodings.forEach((e) {
list.add(RTCRTPCodecWeb.fromJsObject(e));
Expand Down