Skip to content

Conversation

csells
Copy link
Contributor

@csells csells commented Nov 28, 2024

This PR forms the move of the contents of github.com/csells/flutter_ai_toolkit into the github.com/flutter/ai repo.

This PR fixes a single issue: #1

I'm treating this PR as test-example, since it's not part of flutter/flutter, flutter/core or flutter/plugins and neither the Flutter News Toolkit nor the Flutter Casual Games Toolkit have tests.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@csells
Copy link
Contributor Author

csells commented Nov 28, 2024

@domesticmouse
Copy link
Contributor

Hey Chris,

As someone who winds up as maintenance bunny for a log of GitHub hosted projects, I'm wondering how and when we will introduce CI and pub upgrade into this repo. I'm happy to do it as a follow up PR if this isn't something you are comfortable with doing.

Brett

@csells
Copy link
Contributor Author

csells commented Nov 29, 2024

Hey Brett. I don't know a thing about it but I'd like to learn. Can I watch over your shoulder while you add that after we land this PR?

@domesticmouse
Copy link
Contributor

domesticmouse commented Nov 29, 2024

Sure, I'll mark you as the reviewer for the PR to add CI for this repo =)

I added an issue to track this work in #3

@mit-mit
Copy link
Member

mit-mit commented Dec 4, 2024

LGTM from me -- @domesticmouse can you LGTM too?

@domesticmouse
Copy link
Contributor

LGTM 😇

@domesticmouse domesticmouse merged commit f4c7ad6 into flutter:main Dec 4, 2024
1 check passed
@mit-mit mit-mit deleted the copy-from-csells branch December 4, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants