Skip to content

Conversation

@jwren
Copy link
Member

@jwren jwren commented Jul 19, 2025

No description provided.

@jwren jwren force-pushed the tests-03-das branch 5 times, most recently from 0989a7f to ec5d845 Compare July 21, 2025 17:14
@jwren jwren requested review from helin24 and pq July 21, 2025 17:18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open a tracking bug and add links to these TODOs?

It would be great to schedule a review of the disabled tests and having them aggregated in a tracking issue would help I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#21

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I was thinking more like adding them to the TODO itself (as in the flutter todo style).

@jwren
Copy link
Member Author

jwren commented Jul 21, 2025

This is current passing on my mac against version 3.8.1, navigating now why this is not passing here.

@jwren jwren force-pushed the tests-03-das branch 5 times, most recently from cfe51a2 to d336324 Compare July 24, 2025 21:33
@jwren
Copy link
Member Author

jwren commented Jul 24, 2025

FYI - This PR is still a work in progress. @helin24 @pq

The tests run fine on my mac, but not on the linux machine in presubmit, there does not appear to be a flag to get the expected and actual text showing what the diff is causing the failure (unfortunately).

To resolve this, I believe that I will need to get the project working on my linux machine to see the failure within IJ itself.

@jwren jwren force-pushed the tests-03-das branch 3 times, most recently from 6ac6ddb to ef9aefe Compare July 28, 2025 19:59
jwren added 2 commits July 28, 2025 14:20
Add a presubmit job to run the tests over the 'stable', 'beta', 'dev' versions of the Dart SDK.
… on more operating systems as well as more Dart SDK versions.
@jwren jwren merged commit 832ea95 into flutter:main Jul 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants