Skip to content

Remove the rest of the reference to "com.intellij.coverage.*" from the plugin #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Remove the rest of the reference to "com.intellij.coverage.*" from the plugin #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions third_party/src/main/java/com/jetbrains/lang/dart/analyzer/DartAnalysisServerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
import com.google.dart.server.utilities.logging.Logging;
import com.google.gson.JsonObject;
import com.intellij.codeInsight.CodeInsightSettings;
import com.intellij.coverage.CoverageLoadErrorReporter;
import com.intellij.coverage.DummyCoverageLoadErrorReporter;
import com.intellij.openapi.Disposable;
import com.intellij.openapi.application.ApplicationInfo;
import com.intellij.openapi.application.ApplicationManager;
Expand Down Expand Up @@ -1954,15 +1952,10 @@ private void analysis_setSubscriptions() {
}

public @Nullable String execution_createContext(@NotNull String filePath) {
return execution_createContext(filePath, new DummyCoverageLoadErrorReporter());
}

public @Nullable String execution_createContext(@NotNull String filePath, @NotNull CoverageLoadErrorReporter reporter) {
final AnalysisServer server = myServer;
if (server == null) {
String message = "Dart Analysis Server is not available.";
LOG.warn(message);
reporter.reportWarning(message, null);
return null;
}

Expand All @@ -1980,7 +1973,6 @@ public void computedExecutionContext(final String contextId) {
public void onError(final RequestError error) {
logError("execution_createContext()", fileUri, error);
String message = getShortErrorMessage("execution_createContext()", fileUri, error);
reporter.reportError("Execution context creation failed: " + message);
latch.countDown();
}
});
Expand All @@ -1989,8 +1981,6 @@ public void onError(final RequestError error) {

if (latch.getCount() > 0) {
logTookTooLongMessage("execution_createContext", EXECUTION_CREATE_CONTEXT_TIMEOUT, fileUri);
String message = "Execution context creation timed out.";
reporter.reportWarning(message, null);
}
return resultRef.get();
}
Expand Down