Skip to content

Conversation

@jwren
Copy link
Member

@jwren jwren commented Jul 30, 2025

No description provided.

README.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly what this means.

Do I create a new project first? (If so, what kind?)

Or, do I use the "Open" button?

image

Copy link
Member Author

@jwren jwren Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR.

README.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? =>

The Java source code should now be compiled. To run the Dart IntelliJ plugin, from `third_party` run

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the PR.

README.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove "currently"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the PR

@jwren jwren force-pushed the README_setup_instructions_7_30_2025 branch from 68e86b3 to b2e51c7 Compare August 18, 2025 19:01
@jwren jwren requested a review from helin24 August 18, 2025 19:02
README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. The Java source code should now be compiled, to launch an IDE with this plugin, execute the following on the command line (from the `third_party` directory):
5. The Java source code should now be compiled. To launch an IDE with this plugin, execute the following on the command line (from the `third_party` directory):

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`.github/workflows/presubmit.yaml` and in the tests themselves) on the command line run execute:
`.github/workflows/presubmit.yaml` and in the tests themselves), then on the command line run:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jwren jwren changed the title WIP. Initial set of instructions to setup the development of this project Initial set of instructions to setup the development of this project Aug 18, 2025
@jwren jwren force-pushed the README_setup_instructions_7_30_2025 branch from b2e51c7 to 1f7516e Compare August 20, 2025 21:42
@jwren jwren merged commit 73ce02b into flutter:main Aug 20, 2025
7 of 8 checks passed
```

2. Download the latest stable [IntelliJ Ultimate](https://www.jetbrains.com/idea/buy) or [IntelliJ Community](https://www.jetbrains.com/idea/download)
3. From the "Welcome to IntelliJ IDEA" dialog, select "Open" and then select `third_party` directory in this repository.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove trailing period or add one to all list items.

IDE tasks
---------
cleanIdea - Cleans IDEA project files (IML, IPR)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add periods to agree w/ how you formatted Build Tasks. (Or remove them there.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants