-
Notifications
You must be signed in to change notification settings - Fork 3
Change version to 500.0, and the untilBuild to 253.* #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These changes are anticipation of landing the Dart Plugin in coming days from the Google vendor.
Summary of ChangesHello @jwren, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares the project for the upcoming integration of the Dart Plugin from the Google vendor. It updates the plugin's internal version number and extends the compatible IntelliJ Platform build range to accommodate these anticipated changes, ensuring future compatibility and alignment with the new plugin release. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the plugin version to 500.0 and extends the IDE compatibility range by setting pluginUntilBuild to 253.*. While the changes are straightforward, I've identified a minor inconsistency with the versioning format. The pluginVersion does not fully adhere to the SemVer format mentioned in the file's comments. I've provided a suggestion to align it with the standard, which also supports the project's goals of consistency and maintainability as outlined in the style guide.
|
|
||
| # SemVer format -> https://semver.org | ||
| pluginVersion = 89.0 | ||
| pluginVersion = 500.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on line 9 indicates that pluginVersion should follow the SemVer format. To improve consistency and maintainability1, it's best to adhere to the specified format. The SemVer specification requires a MAJOR.MINOR.PATCH structure. The current value 500.0 is missing the patch version. To adhere to the standard, please update it to 500.0.0.
pluginVersion = 500.0.0
Style Guide References
Footnotes
|
presubmit caught this minor issue, created #80 to follow up with |
These changes are anticipation of landing the Dart Plugin in coming days from the Google vendor.