-
Notifications
You must be signed in to change notification settings - Fork 2
[fix] inline removed ActionCenter.getToolWindow
#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @pq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request provides a targeted fix to maintain functionality within the Dart Problems View following a recent platform update. A specific utility method, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a breaking change from the IntelliJ platform by inlining the removed ActionCenter.getToolWindow method. The approach is correct, and I've suggested a small improvement to use a platform constant instead of a hardcoded string for the tool window ID.
However, the fix appears to be incomplete. There is another call to the removed ActionCenter class at DartProblemsView.java:255 (ActionCenter.getToolwindowName()) which was not modified in this pull request. This will likely cause a compilation failure. Please address this as well to fully resolve the issue. Based on the platform changes, it should be replaced with NotificationsManager.getToolWindowId().
Fixes: #80
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.