Skip to content

Conversation

@pq
Copy link
Collaborator

@pq pq commented Nov 17, 2025

Fixes: #80

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gemini-code-assist
Copy link

Summary of Changes

Hello @pq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a targeted fix to maintain functionality within the Dart Problems View following a recent platform update. A specific utility method, getToolWindow, was removed from its original class, ActionCenter. To prevent breakage and ensure the continued ability to activate the 'Notifications' tool window, the necessary logic has been directly embedded into the DartProblemsView class. This ensures stability and compatibility with the updated platform without introducing new dependencies.

Highlights

  • Method Inlining: The getToolWindow method, which was previously part of ActionCenter and has since been removed from its original location, has been inlined directly into DartProblemsView.java.
  • Platform Compatibility: This change addresses a compatibility issue arising from a recent platform update (specifically, a 2025.1 platform change) that led to the removal of the ActionCenter.getToolWindow method.
  • Issue Resolution: The pull request resolves issue DartProblemsView$3$1.hyperlinkActivated, version 2025.2 #80 in the flutter/dart-intellij-third-party repository, ensuring that the Dart Problems View continues to function correctly.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a breaking change from the IntelliJ platform by inlining the removed ActionCenter.getToolWindow method. The approach is correct, and I've suggested a small improvement to use a platform constant instead of a hardcoded string for the tool window ID.

However, the fix appears to be incomplete. There is another call to the removed ActionCenter class at DartProblemsView.java:255 (ActionCenter.getToolwindowName()) which was not modified in this pull request. This will likely cause a compilation failure. Please address this as well to fully resolve the issue. Based on the platform changes, it should be replaced with NotificationsManager.getToolWindowId().

@pq pq merged commit 79ecc37 into flutter:main Nov 17, 2025
8 of 9 checks passed
@pq pq deleted the fix_removedActionCenter_getToolWindow branch November 17, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DartProblemsView$3$1.hyperlinkActivated, version 2025.2

2 participants