Skip to content

Conversation

@pq
Copy link
Collaborator

@pq pq commented Nov 17, 2025

See: #86

(Note that JUnit 3 has nothing like the @Ignore annotation so we need to appeal to a naming convention.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested review from helin24 and jwren November 17, 2025 22:38
@gemini-code-assist
Copy link

Summary of Changes

Hello @pq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue by temporarily disabling a problematic test case, testBoolUsagesWithScope, within the DartServerFindUsagesTest.java file. Since the project uses JUnit 3, which does not support the @Ignore annotation, the test method has been renamed to ignore_testBoolUsagesWithScope to prevent its execution, effectively bypassing the failing or unstable test until a proper fix can be implemented.

Highlights

  • Test Ignorance: A specific test, testBoolUsagesWithScope, in DartServerFindUsagesTest.java is now ignored.
  • Method Renaming: The test method was renamed to ignore_testBoolUsagesWithScope to disable it, adhering to a naming convention for JUnit 3, which lacks a direct @Ignore annotation.
  • Issue Reference: The change directly references and addresses https://github.com/flutter/dart-intellij-third-party/issues/86.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the testBoolUsagesWithScope test by renaming it to follow a convention for ignoring tests in JUnit 3. While this approach is functional, I've provided a suggestion to use the @Ignore annotation from JUnit 4 instead. This is a more modern and maintainable practice, as it allows test runners to explicitly report the test as 'skipped', providing better visibility than simply having the test disappear from reports. This change aligns with the repository's style guide emphasis on maintainability.

@pq pq merged commit 2115647 into flutter:main Nov 17, 2025
9 checks passed
@pq pq deleted the test_ignore_DartServerFindUsagesTest branch November 17, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants