Skip to content

Conversation

@pq
Copy link
Collaborator

@pq pq commented Nov 17, 2025

Ignores remaining tests enumerated in #86

This should turn the presubmits green 🤞


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@gemini-code-assist
Copy link

Summary of Changes

Hello @pq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the stability and reliability of the test suite by temporarily ignoring a set of known failing Dart Analysis Server tests. By disabling these tests, the continuous integration pipeline can maintain a green state, allowing developers to focus on new issues without being distracted by existing, tracked failures. The underlying problems for these tests are being addressed in a separate effort.

Highlights

  • Test Disablement: Several Dart Analysis Server (DAS) tests across two files have been temporarily disabled. These tests were consistently failing and are now prefixed with ignore_ to prevent them from running.
  • Issue Tracking: Each disabled test now includes a comment referencing the GitHub issue https://github.com/flutter/dart-intellij-third-party/issues/86, which tracks the underlying problems causing these failures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables several failing tests by renaming the test methods. While this achieves the goal, I've provided suggestions to use the @org.junit.Ignore annotation instead. This is a more modern and explicit approach that improves maintainability by keeping the original test names, making them easier to track and eventually re-enable. This aligns with Java best practices mentioned in the contribution guidelines.

@pq pq requested review from helin24 and jwren November 17, 2025 23:09
@pq pq merged commit c936e9c into flutter:main Nov 18, 2025
8 of 9 checks passed
@pq pq deleted the tests_disableFailingServerTests branch November 18, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants