-
Notifications
You must be signed in to change notification settings - Fork 2
[tests] ignore failing DAS tests #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @pq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to improve the stability and reliability of the test suite by temporarily ignoring a set of known failing Dart Analysis Server tests. By disabling these tests, the continuous integration pipeline can maintain a green state, allowing developers to focus on new issues without being distracted by existing, tracked failures. The underlying problems for these tests are being addressed in a separate effort. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request disables several failing tests by renaming the test methods. While this achieves the goal, I've provided suggestions to use the @org.junit.Ignore annotation instead. This is a more modern and explicit approach that improves maintainability by keeping the original test names, making them easier to track and eventually re-enable. This aligns with Java best practices mentioned in the contribution guidelines.
Ignores remaining tests enumerated in #86
This should turn the presubmits green 🤞
Contribution guidelines:
dart format.