Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jul 30, 2019

Unblocks Dart SDK rolls

@aam
Copy link
Member

aam commented Jul 30, 2019

Don't you want to include this change into actual dart sdk roll that requires this new dependency?

@bkonyi
Copy link
Contributor Author

bkonyi commented Jul 30, 2019

Don't you want to include this change into actual dart sdk roll that requires this new dependency?

I'm going to start a roll immediately after this lands. It's easier than me trying to fiddle with the script remotely.

@aam
Copy link
Member

aam commented Jul 30, 2019

Don't you want to include this change into actual dart sdk roll that requires this new dependency?

I'm going to start a roll immediately after this lands. It's easier than me trying to fiddle with the script remotely.

I would rather land this DEPS change as part of the dart roll - makes it clear where it came from, makes it easy to revert and bisect if needed.
If you need help doing the roll, let me know - should not be too much problem doing it here.

@aam
Copy link
Member

aam commented Jul 30, 2019

Don't you want to include this change into actual dart sdk roll that requires this new dependency?

I'm going to start a roll immediately after this lands. It's easier than me trying to fiddle with the script remotely.

I would rather land this DEPS change as part of the dart roll - makes it clear where it came from, makes it easy to revert and bisect if needed.
If you need help doing the roll, let me know - should not be too much problem doing it here.

Created #10265

@bkonyi bkonyi closed this Jul 30, 2019
@bkonyi bkonyi deleted the tf_lite_native_dep branch July 30, 2019 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants