Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

aam
Copy link
Member

@aam aam commented Jul 30, 2019

Changes since last roll

80c4954d4d [vm/compiler] Remove unnecessary load in product mode
d1daa375d1 Support the output-directory flag in run_abi_tests.py
8c699b96e5 Migration: fix some erroneous comments in nullability node test.
fc3d23de80 Migration: change graph propagation variables into fields.
3f22f1f5df do not include double-to-int fix by default
8dc24d0919 report dartfix error for unknown fix
1fe2793d37 Improve tests per previous review
00ec685089 [gardening] Fix flutter hhh apply.sh so it clones dependencies added in patch files
871c66cad7 Remove the experimental flag on edit.getPostfixCompletion in the Analysis Server spec
001a77a966 Fix typo in bitwise and doc
6e48c00c46 [gardening] Fix hhh patch apply.sh so it skips newly added, non-existent dependency folders
dddd58b3d3 Report an error when extension declares a member with the same name as declared in Object.
0b9668d3c5 [gardening] Follow-up to 038250d99e5c430c69f7b92f0e71d935a54ab56f - fix patch file
645c985201 Resolve references to static members of extensions
713c2227b2 [bots] Enable co19 tests on dartkb bots
821efa642c Update error messages in kernel_loader.cc
038250d99e [gardening] Fix flutter hhh with patch for https://github.com/dart-lang/sdk/commit/5d5a0c0164fa013ebcfa7a14bdfce59d8e11f043
b011a80478 Extract ImportsVerifier and company.
92633cf4af Tests for using getter in MethodInvocation.
c12deff784 Test that AMBIGUOUS_EXPORT is reported for extensions.
33ce54e45d Don't try to start ML completion isolate on 32 bit systems
795290a614 [vm/compiler] Free, not delete, buffer taken from TextBuffer.
55fb47e1de Migration: Add an analysis_options.yaml file.
4932ee6d80 Reland "[vm/compiler] Use pragmas instead of separately-maintained lists for inlining."
e147c3e0c8 Migration: ensure that NodeBuilder visits executable metadata and constructor initializers.
db16503080 Migration: test generic field initializers
f822dfa3ea Reland "[vm/compiler] Implement new inlining pragmas."
5f627b7a54 [vm/compiler] Fix inliner bug which did not emit an explicit unboxing instruction for the value
5e6b200d2a [infra] Add previous commit info to results records for new tests
b87386da26 [vm/compiler] Add S-expression deserializer.
50c68d1f30 (origin/base) [Test] Fixes flaky racing in lib_2/isolate/spawn_uri_test.
d6e9e15cf1 [vm] Clear recognized method info on dynamic invocation forwarders.
6ebaa7c587 [vm service lib] expose the current service protocol version as a field
440d1f3578 [dart2js] Register TypeUse for HAsCheck SSA nodes.
4b35a044c9 [dart2js] new-rti: Make all closures have class type 'Closure'
f9f005cdb9 Tool to automatically update expectations in static error tests.
90c1e5a35b [dart2js] Remove _ticks from new RTI.
b21b6f7086 Set resolution types for extension override method invocation.
8f0b6c89e2 Fix uri of dart_completion_ranking_internal_test.dart import
b3293a4263 [vm/bytecode] Use faster method/field lookups
928dff2b3e [dart2js] Omit Object from new RTI type rules.
3d578c7037 [dart2js] new-rti: recognize 'raw' types as precise abstract values
752f06fff5 Make sure to import and run completion_ranking_test_internal.dart in test_all.dart
db796d5b96 Fix for bad handling of predict response from model isolate
d54ab60990 Fix TODO now that == considers NullabilitySuffix
2f96be9ee3 [analyzer] Allow references of 'this' in late field initializers
73cbfd3826 [dart2js] new-rti: Emit new rti for constants
60029e19fa Migration: add support for constructor field initializers.
8db1408ffd [vm] Use RareType for fast is-checks optimization instead of TypeArguments::null() comparison
60725e7030 Report an error when 'covariant' is used in extension.
1a0fe21fb2 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
436a505e00 Migration: fix handling of constructors that redirect to the unnamed constructor.
a048eb9bbc Resolve operators from extensions
0a2fb22230 [vm/bytecode] Use simpleInstanceOf for rare types in bytecode
c3baca79b3 [vm/service] Fix flaky errors in SampleProfile.load() and re-enable service/get_native_allocation_samples_test
a650cb67f7 Make sure that completion_ranking_test.dart is loaded in test_all.dart
8cde797a49 Move more diagnostic tests to separate files
b9dbdffe6f [cfe] Remove generics from LibraryBuilder, FieldBuilder and ProcedureBuilder
1b06a1cd1b [cfe] Remove generics from TypeDeclarationBuilder hierarchy
3992be71c7 [cfe] Add `this` parameter to extension methods
28a7369146 [cfe] Merge KernelClassBuilder into ClassBuilder
bbd0bee625 Include 'exists' flag into the linked library signature.
d116c67192 Fix promoteToNonNull() for the case when the type parameter bound is null.
92faca77d9 [vm/compiler] Use simpleInstanceOf for is checks if the type to test against is a rare type
fc54f900de [vm] Cleanup some outdated code from hot-reload (and deferred loading)
fc82ed2286 Isolate-based CompletionRanking
e5a6fca9a4 Use isDartCoreDouble/Int/Num in TypeSystem.
6d55c7745f Revert a test expectation difference.
477c11aa9b Skip Never during indexing.
6c56e98162 Visit extension elements and children of extensions.
58470142b7 [infra] Fix return type of async function in approve_results.dart
fa22f034d7 [infra] Handle more than 100 tryjobs in approve_results
a255147ea0 Revert "Fix example syntax"
bdec682558 [Test] Fixes flakiness in spawn_function_test caused by racing.
5964cb97ec Fix example syntax
4ed2ce7188 [dartfix] adjust the help text for dartfix
ec5bf35152 Update analysis_server and analyzer_plugin to stop using DartType.isSubtypeOf().

Changes since last roll

```
80c4954 (HEAD, origin/master, origin/HEAD) [vm/compiler] Remove unnecessary load in product mode
d1daa37 Support the output-directory flag in run_abi_tests.py
8c699b9 Migration: fix some erroneous comments in nullability node test.
fc3d23d Migration: change graph propagation variables into fields.
3f22f1f do not include double-to-int fix by default
8dc24d0 report dartfix error for unknown fix
1fe2793 Improve tests per previous review
00ec685 [gardening] Fix flutter hhh apply.sh so it clones dependencies added in patch files
871c66c Remove the experimental flag on edit.getPostfixCompletion in the Analysis Server spec
001a77a Fix typo in bitwise and doc
6e48c00 [gardening] Fix hhh patch apply.sh so it skips newly added, non-existent dependency folders
dddd58b Report an error when extension declares a member with the same name as declared in Object.
0b9668d [gardening] Follow-up to 038250d - fix patch file
645c985 Resolve references to static members of extensions
713c222 [bots] Enable co19 tests on dartkb bots
821efa6 Update error messages in kernel_loader.cc
038250d [gardening] Fix flutter hhh with patch for dart-lang/sdk@5d5a0c0
b011a80 Extract ImportsVerifier and company.
92633cf Tests for using getter in MethodInvocation.
c12deff Test that AMBIGUOUS_EXPORT is reported for extensions.
33ce54e Don't try to start ML completion isolate on 32 bit systems
795290a [vm/compiler] Free, not delete, buffer taken from TextBuffer.
55fb47e Migration: Add an analysis_options.yaml file.
4932ee6 Reland "[vm/compiler] Use pragmas instead of separately-maintained lists for inlining."
e147c3e Migration: ensure that NodeBuilder visits executable metadata and constructor initializers.
db16503 Migration: test generic field initializers
f822dfa Reland "[vm/compiler] Implement new inlining pragmas."
5f627b7 [vm/compiler] Fix inliner bug which did not emit an explicit unboxing instruction for the value
5e6b200 [infra] Add previous commit info to results records for new tests
b87386d [vm/compiler] Add S-expression deserializer.
50c68d1 (origin/base) [Test] Fixes flaky racing in lib_2/isolate/spawn_uri_test.
d6e9e15 [vm] Clear recognized method info on dynamic invocation forwarders.
6ebaa7c [vm service lib] expose the current service protocol version as a field
440d1f3 [dart2js] Register TypeUse for HAsCheck SSA nodes.
4b35a04 [dart2js] new-rti: Make all closures have class type 'Closure'
f9f005c Tool to automatically update expectations in static error tests.
90c1e5a [dart2js] Remove _ticks from new RTI.
b21b6f7 Set resolution types for extension override method invocation.
8f0b6c8 Fix uri of dart_completion_ranking_internal_test.dart import
b3293a4 [vm/bytecode] Use faster method/field lookups
928dff2 [dart2js] Omit Object from new RTI type rules.
3d578c7 [dart2js] new-rti: recognize 'raw' types as precise abstract values
752f06f Make sure to import and run completion_ranking_test_internal.dart in test_all.dart
db796d5 Fix for bad handling of predict response from model isolate
d54ab60 Fix TODO now that == considers NullabilitySuffix
2f96be9 [analyzer] Allow references of 'this' in late field initializers
73cbfd3 [dart2js] new-rti: Emit new rti for constants
60029e1 Migration: add support for constructor field initializers.
8db1408 [vm] Use RareType for fast is-checks optimization instead of TypeArguments::null() comparison
60725e7 Report an error when 'covariant' is used in extension.
1a0fe21 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
436a505 Migration: fix handling of constructors that redirect to the unnamed constructor.
a048eb9 Resolve operators from extensions
0a2fb22 [vm/bytecode] Use simpleInstanceOf for rare types in bytecode
c3baca7 [vm/service] Fix flaky errors in SampleProfile.load() and re-enable service/get_native_allocation_samples_test
a650cb6 Make sure that completion_ranking_test.dart is loaded in test_all.dart
8cde797 Move more diagnostic tests to separate files
b9dbdff [cfe] Remove generics from LibraryBuilder, FieldBuilder and ProcedureBuilder
1b06a1c [cfe] Remove generics from TypeDeclarationBuilder hierarchy
3992be7 [cfe] Add `this` parameter to extension methods
28a7369 [cfe] Merge KernelClassBuilder into ClassBuilder
bbd0bee Include 'exists' flag into the linked library signature.
d116c67 Fix promoteToNonNull() for the case when the type parameter bound is null.
92faca7 [vm/compiler] Use simpleInstanceOf for is checks if the type to test against is a rare type
fc54f90 [vm] Cleanup some outdated code from hot-reload (and deferred loading)
fc82ed2 Isolate-based CompletionRanking
e5a6fca Use isDartCoreDouble/Int/Num in TypeSystem.
6d55c77 Revert a test expectation difference.
477c11a Skip Never during indexing.
6c56e98 Visit extension elements and children of extensions.
5847014 [infra] Fix return type of async function in approve_results.dart
fa22f03 [infra] Handle more than 100 tryjobs in approve_results
a255147 Revert "Fix example syntax"
bdec682 [Test] Fixes flakiness in spawn_function_test caused by racing.
5964cb9 Fix example syntax
4ed2ce7 [dartfix] adjust the help text for dartfix
ec5bf35 Update analysis_server and analyzer_plugin to stop using DartType.isSubtypeOf().
```
@aam aam mentioned this pull request Jul 30, 2019
@aam aam requested review from bkonyi and a-siva July 30, 2019 20:37
@bkonyi
Copy link
Contributor

bkonyi commented Jul 30, 2019

Thanks @aam!

@aam aam merged commit 6bd2f53 into flutter:master Jul 30, 2019
@aam aam deleted the roll-dart-20190730 branch July 30, 2019 20:50
aam added a commit to aam/engine that referenced this pull request Jul 30, 2019
This reverts commit 6bd2f53 as it
breaks android release arm64 build on Windows.
aam added a commit to aam/engine that referenced this pull request Jul 30, 2019
This reverts commit 6bd2f53 as it
breaks android release arm64 build on Windows.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants