Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Dec 28, 2019

Adds a font subsetting utillity to the engine build.

This is meant to be consumed by the flutter tool to help with glyph shaking. Once it lands in tree we can update the recipes to upload it to storage along with the other host artifacts.

Tagged a bunch of people for review:

@zanderso and @jonahwilliams for evaluation of how this will be used by the tool

@jason-simmons @GaryQian @chinmaygarde because they probably know more about harfbuzz than I do, and general engine review.

@willlarche FYI (and feel free to give feedback as well).

@GaryQian
Copy link
Contributor

Is there an issue this fixes for more context?

@dnfield
Copy link
Contributor Author

dnfield commented Dec 28, 2019

Fixes flutter/flutter#43642

@dnfield dnfield removed the request for review from stuartmorgan-g December 28, 2019 04:38
@dnfield
Copy link
Contributor Author

dnfield commented Dec 28, 2019

I was expecting this to run the tests I wrote on all platforms, but it looks like not unfortuantely. That will require a recipe change, or that I make these tests run under the "engine" category for now. I'm going to push something up that does that at least temporarily to try to get them to run on Windows, since I haven't tested it there yet.

@jonahwilliams
Copy link
Contributor

Seems like this would be fairly straightforward to incorporate into the asset build, provided that we already knew the subset of fonts needed? I'm assuming that later part is where the kernel parsing comes in

@dnfield
Copy link
Contributor Author

dnfield commented Dec 29, 2019

Seems like this would be fairly straightforward to incorporate into the asset build, provided that we already knew the subset of fonts needed? I'm assuming that later part is where the kernel parsing comes in

Yes

@dnfield
Copy link
Contributor Author

dnfield commented Dec 29, 2019

Having issues with the test. I'll look at it some more later. The script seems to try to compare before the process has finished writing files

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 8, 2020
flutter/engine@3851981...3f52888

git log 3851981..3f52888 --first-parent --oneline
2020-01-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia d445e2b6fcf1..91e0d7526944 (44 commits) (flutter/engine#15232)
2020-01-07 dnfield@google.com Font subset (flutter/engine#14828)
2020-01-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from MwGkB... to xYmDF... (flutter/engine#15145)
2020-01-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Kom_K... to nbeLe... (flutter/engine#15149)
2020-01-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6791ee2f8059..d445e2b6fcf1 (1 commits) (flutter/engine#15148)
2020-01-06 skia-flutter-autoroll@skia.org Roll src/third_party/dart 76e3faa9824e..bebc7d3af5bd (1 commits) (flutter/engine#15146)
2020-01-04 skia-flutter-autoroll@skia.org Roll src/third_party/dart 2f57602411b3..76e3faa9824e (37 commits) (flutter/engine#15143)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
bkonyi pushed a commit to flutter/flutter that referenced this pull request Jan 9, 2020
flutter/engine@3851981...3f52888

git log 3851981..3f52888 --first-parent --oneline
2020-01-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia d445e2b6fcf1..91e0d7526944 (44 commits) (flutter/engine#15232)
2020-01-07 dnfield@google.com Font subset (flutter/engine#14828)
2020-01-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from MwGkB... to xYmDF... (flutter/engine#15145)
2020-01-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Kom_K... to nbeLe... (flutter/engine#15149)
2020-01-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6791ee2f8059..d445e2b6fcf1 (1 commits) (flutter/engine#15148)
2020-01-06 skia-flutter-autoroll@skia.org Roll src/third_party/dart 76e3faa9824e..bebc7d3af5bd (1 commits) (flutter/engine#15146)
2020-01-04 skia-flutter-autoroll@skia.org Roll src/third_party/dart 2f57602411b3..76e3faa9824e (37 commits) (flutter/engine#15143)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants