Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

4x4.png -> 2x2.png; this file is actually 2x2 #20005

Merged
merged 8 commits into from
Jul 29, 2020
Merged

4x4.png -> 2x2.png; this file is actually 2x2 #20005

merged 8 commits into from
Jul 29, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 24, 2020

The checked in file is 2 pixels by 2 pixels. Just renames it.

@dnfield dnfield requested a review from iskakaushik July 24, 2020 17:00
@auto-assign auto-assign bot requested a review from flar July 24, 2020 17:00
@nturgut
Copy link
Contributor

nturgut commented Jul 25, 2020

This will still fail on Web Engine tests, @jason-simmons also sent this fix: #20024

iskakaushik
iskakaushik approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik
Copy link
Contributor

I multiplied an additional time when naming it looks like :-/

@nturgut
Copy link
Contributor

nturgut commented Jul 26, 2020

Looks like this one passed all the LUCI tests, which makes sense since this PR have fixed dependency issues for web_ui build.

However, engine still has a broken build which successfully run on many other occasions with the latest commit, therefore we believe it is an issue with dart tags and caching. (Ex: https://ci.chromium.org/p/flutter/builders/prod/Mac%20Web%20Engine/1018, https://ci.chromium.org/p/flutter/builders/try/Mac%20Web%20Engine/7002)

Shall we try to merge this PR on Monday morning to see if we can get a green build?

/cc @godofredoc @christopherfujino

@dnfield
Copy link
Contributor Author

dnfield commented Jul 26, 2020

Why is the cirius check still failing?

@nturgut
Copy link
Contributor

nturgut commented Jul 27, 2020

Why is the cirius check still failing?

That tests fails due to flutter. I think that one will only get fixed once we roll the engine. /cc @jonahwilliams know the plans on the roll.

@jonahwilliams
Copy link
Contributor

I'm not going to roll anything until its a workday again 😄

@dnfield dnfield merged commit b3ca41a into flutter:master Jul 29, 2020
@dnfield dnfield deleted the 2x2 branch July 29, 2020 00:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2020
@engine-flutter-autoroll
b3ca41a 4x4.png -> 2x2.png; this file is actually 2x2 (flutter/engine…
5ce45f2 
…#20005)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2020
@engine-flutter-autoroll
b3ca41a 4x4.png -> 2x2.png; this file is actually 2x2 (flutter/engine…
0cc9e5b 
…#20005)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flar flar Awaiting requested review from flar

1 more reviewer

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dnfield @nturgut @iskakaushik @jonahwilliams @googlebot