Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

remove usage of dartdev command #20011

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

jonahwilliams
Copy link
Contributor

Description

This is broken on head, just use pub itself.

@jonahwilliams jonahwilliams requested a review from dnfield July 24, 2020 19:14
@auto-assign auto-assign bot requested a review from liyuqian July 24, 2020 19:14
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @whesse this is a bug in dart and we're using the right command.

Should we just hold off until Dart rolls through with the right fix(es)?

Also, nit: new line at EOF

/cc @jason-simmons

@jonahwilliams
Copy link
Contributor Author

I have no interest in waiting for more dart rolls

@jonahwilliams
Copy link
Contributor Author

Landing to fix build

@jonahwilliams jonahwilliams merged commit 3596b9b into flutter:master Jul 24, 2020
@jonahwilliams jonahwilliams deleted the fix_pub_breakage branch July 24, 2020 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants