This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix gclient runhooks for windows #20014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
force-pushed
the
windows-bs
branch
from
f236415 to
ccc65e0
Compare
jason-simmons
approved these changes
Jul 24, 2020
tools/run_third_party_dart.py
Outdated
| subprocess.call(["src/third_party/dart/tools/sdks/dart-sdk/bin/pub", "global", "run", "generate_package_config:generate_from_legacy", "src/flutter/tools/const_finder/.packages"]) | ||
| pub = "src/third_party/dart/tools/sdks/dart-sdk/bin/pub" | ||
| if os.name == "nt": | ||
| pub = "src/third_party/dart/tools/sdks/dart-sdk/bin/pub.bat" |
There was a problem hiding this comment.
Actually I just tried this on my local Windows box and it only seems to work with backslashes, like:
subprocess.call(["bin\\cache\\dart-sdk\\bin\\pub.bat"])
There was a problem hiding this comment.
It was working for several weeks when I was using dart pub on windows
There was a problem hiding this comment.
switched to backslashes
There was a problem hiding this comment.
And then you can just conditionally define a string called BAT based on whether it's nt and append that to the output of path.join.
dnfield
reviewed
Jul 24, 2020
tools/run_third_party_dart.py
Outdated
| pub = "src/third_party/dart/tools/sdks/dart-sdk/bin/pub" | ||
| if os.name == "nt": | ||
| pub = "src/third_party/dart/tools/sdks/dart-sdk/bin/pub.bat" | ||
| subprocess.call([pub, "global", "activate", "-spath", "./src/flutter/tools/generate_package_config"]) |
|
runhooks passed on windows, landing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pub is pub.bat on windows