Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add Dart 2.10 annotations to the web engine sources #20019

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

jason-simmons
Copy link
Member

No description provided.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nturgut
Copy link
Contributor

nturgut commented Jul 24, 2020

I'm not sure why we needed to add these versions instead of changing the file therefore I have question :)

Do we need to also update the unit test files: https://github.com/flutter/engine/blob/master/lib/web_ui/test/text_editing_test.dart#L5

And the test harness files: https://github.com/flutter/engine/blob/master/lib/web_ui/dev/felt.dart#L5

@jonahwilliams
Copy link
Contributor

The unit tests do not need to be updated because they have specifically opted out of nnbd, that is fine. The issue is that the increase in dart version caused the previously opted-in libraries to act as if they were opted out

@nturgut
Copy link
Contributor

nturgut commented Jul 24, 2020

The unit tests do not need to be updated because they have specifically opted out of nnbd, that is fine. The issue is that the increase in dart version caused the previously opted-in libraries to act as if they were opted out

Thanks!

@jason-simmons jason-simmons merged commit 02c11ac into flutter:master Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants