This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix inconsistent enum/class private member naming #32409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes that model enums in dart:ui typically name fields modelling the enum values as `_kFooIndex`. This associated value matches the enum value from embedder.h. In #32408 we add a test that verifies that dart:ui classes model the same set of values in the native implementation, the web_ui implementation, and the embedder API. Testing this is much simpler if we use consistent naming for all enum values. Issue: #32408
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
dnfield
approved these changes
Apr 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2022
* 9b3117a Create `ImageFilter.dilate`/`ImageFilter.erode` (flutter/engine#32334) * 92a6ade Roll Fuchsia Mac SDK from m_-rjFvCk... to hJaq9O7XI... (flutter/engine#32402) * 31fd1bb Roll Fuchsia Linux SDK from 5abhmXb9Q... to WdxX5Sqix... (flutter/engine#32403) * f088801 Roll Skia from 5215ec1ab9cd to fd9c66e18030 (1 revision) (flutter/engine#32406) * ac21195 Fix inconsistent enum/class private member naming (flutter/engine#32409) * 75e7cfd Fix deltas when selection is active and composing begins on MacOS (flutter/engine#32412) * 7e5989b Fix SemanticsAction naming consistency (flutter/engine#32411) * 1b3e9dc Fix a crash when setting clipboardData to null on iOS (flutter/engine#32413) * ef50b28 Roll Fuchsia Linux SDK from WdxX5Sqix... to PmeDIogNb... (flutter/engine#32422) * b48d65e Roll Fuchsia Mac SDK from hJaq9O7XI... to WBAQhRswX... (flutter/engine#32423)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes that model enums in dart:ui typically name fields modelling the
enum values as
_kFooIndex. This associated value matches the enumvalue from embedder.h.
In #32408 we add a test that
verifies that dart:ui classes model the same set of values in the native
implementation, the web_ui implementation, and the embedder API. Testing
this is much simpler if we use consistent naming for all enum values.
Issue: #32408
No test changes since this changes private variable names only. Test will
be added in #32408. This clears the
way for that patch to land.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.