This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix a crash when setting clipboardData to null on iOS #32413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2022 14:42
jmagman
reviewed
Apr 4, 2022
shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm
Outdated
Show resolved
Hide resolved
Comment on lines
40
to
44
| __block bool value; | ||
| FlutterResult result = ^(id result) { | ||
| called = true; | ||
| value = result[@"value"]; | ||
| value = [result[@"value"] boolValue]; | ||
| }; |
There was a problem hiding this comment.
The __block pattern that was here and you copied is kind of hard to read imo since the assertion about the value is after the method call, how about:
XCTestExpectation *hasStringsExpectation = [self expectationWithDescription:@"hasStrings"];
FlutterResult result = ^(id result) {
XCTAssertTrue(result[@"value"]);
[hasStringsExpectation fulfill];
};
...
[self waitForExpectationsWithTimeout:1 handler:nil];At the least these should be BOOL and not bool and XCTAssertTrue(called);
added 2 commits
April 4, 2022 15:22
|
@jmagman Updated. PTAL |
jmagman
reviewed
Apr 4, 2022
| @"PointerData.time_stamp should be equal to NSProcessInfo.systemUptime"); | ||
| } | ||
| @end | ||
| //// Copyright 2013 The Flutter Authors. All rights reserved. |
There was a problem hiding this comment.
Guessing you didn't mean to check this in.
added 2 commits
April 4, 2022 16:23
cyanglaz
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2022
* 9b3117a Create `ImageFilter.dilate`/`ImageFilter.erode` (flutter/engine#32334) * 92a6ade Roll Fuchsia Mac SDK from m_-rjFvCk... to hJaq9O7XI... (flutter/engine#32402) * 31fd1bb Roll Fuchsia Linux SDK from 5abhmXb9Q... to WdxX5Sqix... (flutter/engine#32403) * f088801 Roll Skia from 5215ec1ab9cd to fd9c66e18030 (1 revision) (flutter/engine#32406) * ac21195 Fix inconsistent enum/class private member naming (flutter/engine#32409) * 75e7cfd Fix deltas when selection is active and composing begins on MacOS (flutter/engine#32412) * 7e5989b Fix SemanticsAction naming consistency (flutter/engine#32411) * 1b3e9dc Fix a crash when setting clipboardData to null on iOS (flutter/engine#32413) * ef50b28 Roll Fuchsia Linux SDK from WdxX5Sqix... to PmeDIogNb... (flutter/engine#32422) * b48d65e Roll Fuchsia Mac SDK from hJaq9O7XI... to WBAQhRswX... (flutter/engine#32423)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash is described in flutter/flutter#101234
The fix is to make sure the argument is a String before propagating the value to the paste board object.
This PR also fixed an existing false positive test. The
testHasStringstest passes because we were checking if an object is nil instead of checking the actual bool value. The test should have failed because the wrong method channel name was used.Fixes: flutter/flutter#101234
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.