This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] fix subpass collapse pass ending logic #40057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Mar 3, 2023
impeller/entity/entity_unittests.cc
Outdated
| @@ -85,15 +85,19 @@ class TestPassDelegate final : public EntityPassDelegate { | |||
|
|
|||
| private: | |||
| const std::optional<Rect> coverage_; | |||
| bool collapse_; | |||
There was a problem hiding this comment.
Nit: Default it, or if it set in a ctor, const bool
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 40057, due to - The status or check suite Linux Android clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bdero
approved these changes
Mar 3, 2023
| @@ -38,6 +40,7 @@ class InlinePassContext { | |||
| std::shared_ptr<RenderPass> pass_; | |||
| uint32_t pass_count_ = 0; | |||
| uint32_t total_pass_reads_ = 0; | |||
| bool collapsed_parent_pass_ = false; | |||
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during investigation of opacity optimizations, currently OnRender will unconditionally end the current pass - but this is incorrect if we're merged into the parent pass. Detect this case and ensure that the collapsed child gets the same render target and render pass.