Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Finish making shell/platform/linux/... compatible with .clang-tidy. #48297

Merged

Conversation

matanlurey
Copy link
Contributor

No description provided.

@matanlurey matanlurey added the test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md label Nov 21, 2023
@matanlurey matanlurey marked this pull request as ready for review November 21, 2023 23:27
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey merged commit be9e2c4 into flutter:main Nov 21, 2023
@matanlurey matanlurey deleted the engine-tidy-shell-platform-linux branch November 21, 2023 23:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 22, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 22, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 22, 2023
…138861)

flutter/engine@7cf9d90...1ae1d53

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) (flutter/engine#48299)
2023-11-22 jonahwilliams@google.com [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/linux/...` compatible with `.clang-tidy`. (flutter/engine#48297)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/android/...` compatible with `.clang-tidy`. (flutter/engine#48296)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48295)
2023-11-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293)
2023-11-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Q3HcTitDF90Z to IK4xyRtZkDwq

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
…lutter#138861)

flutter/engine@7cf9d90...1ae1d53

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) (flutter/engine#48299)
2023-11-22 jonahwilliams@google.com [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/linux/...` compatible with `.clang-tidy`. (flutter/engine#48297)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/android/...` compatible with `.clang-tidy`. (flutter/engine#48296)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48295)
2023-11-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293)
2023-11-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Q3HcTitDF90Z to IK4xyRtZkDwq

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects: desktop platform-linux test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants