[Impeller] fix GLES image upload. #52430
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| }; | ||
| if (context->GetBackendType() == | ||
| impeller::Context::BackendType::kOpenGLES) { | ||
| io_runner->PostTask(upload_texture_and_invoke_result); |
There was a problem hiding this comment.
Hmm, I would have assumed that in the backend implementation, UploadTextureToFoo would rethread to a worker on a thread that returns true for CanReactorReactOnCurrentThreadNow. Its unfortunate we have to care about the backend here. Can we file an issue to track that that down? This is fine though.
There was a problem hiding this comment.
Done: flutter/flutter#147520
jonahwilliams
added
the
autosubmit
…147532) flutter/engine@752b146...399837d 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from 27e872349963 to f7bfa8eef5b5 (1 revision) (flutter/engine#52436) 2024-04-29 jonahwilliams@google.com [Impeller] fix GLES image upload. (flutter/engine#52430) 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from aeab79038011 to 27e872349963 (1 revision) (flutter/engine#52435) 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from c720e2446926 to aeab79038011 (1 revision) (flutter/engine#52434) 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from 1a5436d50954 to c720e2446926 (1 revision) (flutter/engine#52433) 2024-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bIUvi3y4gRFxMSKV3... to TFm2_qWC2xpkzk8QS... (flutter/engine#52432) 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from e3dfcd1b25af to 1a5436d50954 (1 revision) (flutter/engine#52431) 2024-04-28 robert.ancell@canonical.com Use a AT-SPI socket/plug to export the Flutter accessibility state. (flutter/engine#52355) 2024-04-28 jonahwilliams@google.com [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423) 2024-04-28 jonahwilliams@google.com [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from bIUvi3y4gRFx to TFm2_qWC2xpk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TLDR: this was a load bearing closure.
See https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20complex_layout_scroll_perf_impeller_gles__timeline_summary/1492/overview