This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] allow cloning a rectangle packer with an increased size. #52563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
force-pushed
the
update_skyline
branch
from
53b207b to
f2c2a28
Compare
jonahwilliams
commented
May 5, 2024
| @@ -129,13 +131,13 @@ void SkylineRectanglePacker::addSkylineLevel(int skylineIndex, | |||
| newSegment.width_ = width; | |||
| skyline_.insert(std::next(skyline_.begin(), skylineIndex), newSegment); | |||
|
|
|||
| FML_DCHECK(newSegment.x_ + newSegment.width_ <= this->width()); | |||
| FML_DCHECK(newSegment.y_ <= this->height()); | |||
| FML_CHECK(newSegment.x_ + newSegment.width_ <= this->width()); | |||
There was a problem hiding this comment.
just for testing..
added 3 commits
May 4, 2024 20:16
chinmaygarde
approved these changes
May 7, 2024
| /// This method is used for growing the glyph atlas while keeping | ||
| /// existing glyphs in place. The width of the rectangle packer | ||
| /// cannot be increased. | ||
| virtual std::unique_ptr<RectanglePacker> Clone(int scale) = 0; |
There was a problem hiding this comment.
Nit: Consider uint32_t for the scale as a negative scale makes no sense.
| /// @return A new rectangle packer. | ||
| /// | ||
| /// This method is used for growing the glyph atlas while keeping | ||
| /// existing glyphs in place. The width of the rectangle packer |
There was a problem hiding this comment.
existing rects instead of glyphs.
| TEST(TypographerTest, CanCloneRectanglePackerEmpty) { | ||
| auto skyline = RectanglePacker::Factory(256, 256); | ||
|
|
||
| EXPECT_EQ(skyline->percentFull(), 0); |
There was a problem hiding this comment.
In a later patch, we should consider a refactor to use PascalCase like in the rest of the engine.
There was a problem hiding this comment.
I just did that here, it was easy enough
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 7, 2024
…147938) flutter/engine@5d94a52...d88b7db 2024-05-07 jonahwilliams@google.com [Impeller] allow cloning a rectangle packer with an increased size. (flutter/engine#52563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#138798
Allow cloning a rectangle packer with all existing skylines preserved, but the size increased. This will allow us to preserve the positioning and state of all glyphs when the atlas size is increased, which is necessary for the "blit contents to top right of new texture" approach for improving append performance.
EDIT: I mean top left!