Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] added test for bgra10xr png encoding #53182

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jun 3, 2024

fixes: flutter/flutter#148851
depends on:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke marked this pull request as ready for review June 5, 2024 21:29
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@gaaclarke gaaclarke merged commit f51e0ad into flutter:main Jun 5, 2024
28 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 6, 2024
…149778)

flutter/engine@f377330...f51e0ad

2024-06-05 30870216+gaaclarke@users.noreply.github.com [Impeller] added test for bgra10xr png encoding (flutter/engine#53182)
2024-06-05 jonahwilliams@google.com [Impeller] correctly map DL non-mipmap sample mode to non-mipmap sample mode. (flutter/engine#53161)
2024-06-05 fujino@google.com Update testing/skia_gold_client/README.md (flutter/engine#53233)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Impeller][regression] image.toByteData fails to convert raster image to PNG.
3 participants