[Impeller] correctly map DL non-mipmap sample mode to non-mipmap sample mode. #53161
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
force-pushed
the
check_131194
branch
from
5f26178 to
d9cda9e
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
changed the title
| desc.min_filter = desc.mag_filter = impeller::MinMagFilter::kLinear; | ||
| desc.mip_filter = impeller::MipFilter::kBase; |
There was a problem hiding this comment.
With this change FilterQuality.low will imply mipmaps aren't used on Skia or Impeller. No other changes.
|
test = 🤷♂️ |
jonahwilliams
added
the
autosubmit
…149778) flutter/engine@f377330...f51e0ad 2024-06-05 30870216+gaaclarke@users.noreply.github.com [Impeller] added test for bgra10xr png encoding (flutter/engine#53182) 2024-06-05 jonahwilliams@google.com [Impeller] correctly map DL non-mipmap sample mode to non-mipmap sample mode. (flutter/engine#53161) 2024-06-05 fujino@google.com Update testing/skia_gold_client/README.md (flutter/engine#53233) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Match DL/Skia sampling defaults. This does not change the default SamplerDescriptor value, but that is irrelevant as any draws from the framework will pass through DL conversion.
The SamplerDescriptor default of nearest is generally a good idea.
Fixes flutter/flutter#148253