[Impeller] Expand fast gradient to all shapes. #53254
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Show me the goldens! |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
added
the
autosubmit
…149848) flutter/engine@31804a2...bf1a487 2024-06-06 jonahwilliams@google.com [Impeller] Expand fast gradient to all shapes. (flutter/engine#53254) 2024-06-06 skia-flutter-autoroll@skia.org Roll Skia from 1211df22d135 to 41896477ca14 (1 revision) (flutter/engine#53258) 2024-06-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 62e8607e1410 to 8e05acb354f5 (1 revision) (flutter/engine#53257) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of flutter/flutter#148651
allows the fast gradient to apply to non-rect shapes where the start/end are still on the coverage rect. Goldens are slightly different but seem close enough?