[Impeller] move aiks text tests to DL. #54293

jonahwilliams · 2024-08-01T21:07:23Z

Part of flutter/flutter#142054

flutter-dashboard · 2024-08-04T20:11:03Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #54293 at sha b091bfb

flutter-dashboard · 2024-08-06T17:38:31Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #54293 at sha 8019b83

flutter-dashboard · 2024-08-06T18:57:35Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #54293 at sha 030afbe

jonahwilliams · 2024-08-06T19:57:18Z

I'm looking at an issue with SiblingSaveLayerBoundsAreRespected . It looks like the saveLayer bounds are always treated as tight with aiks, but are advisory in display list - leading to the saveLayer expanding instead of clipping. Since this is the current behavior this PR isn't breaking anything there, but perhaps I should disable/remove the test as it doesn't actually demonstrate what the expected rendering is?

flutter-dashboard · 2024-08-06T20:05:39Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #54293 at sha 397ca9b

flar · 2024-08-06T21:17:06Z

I'm looking at an issue with SiblingSaveLayerBoundsAreRespected . It looks like the saveLayer bounds are always treated as tight with aiks, but are advisory in display list - leading to the saveLayer expanding instead of clipping. Since this is the current behavior this PR isn't breaking anything there, but perhaps I should disable/remove the test as it doesn't actually demonstrate what the expected rendering is?

The intent is to include the tight bounds with the user bounds as a clip:

engine/display_list/dl_builder.cc

Line 617 in 206e86e

if (layer_op->options.bounds_from_caller()) {

flar · 2024-08-06T21:20:23Z

impeller/display_list/aiks_dl_basic_unittests.cc

+TEST_P(AiksTest, SiblingSaveLayerBoundsAreRespected) {
+  DisplayListBuilder builder;
+  DlPaint paint;
+  SkRect rect = SkRect::MakeXYWH(0, 0, 1000, 1000);


I don't remember where it caused a problem but in some tool I've used to look at goldens a transparent background with black stuff drawn on it just looks like a giant field of black, so I usually paint a background color in my tests...

jonahwilliams · 2024-08-06T22:08:23Z

Ahh found the bug!

flutter-dashboard · 2024-08-06T22:55:14Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #54293 at sha 776dc12

jonahwilliams · 2024-08-07T00:14:00Z

The rrect changes are a bit odd too, but I think the Skia RRect constructor must be different from the impeller version. Otherwise ready for review, I've left the untriaged goldens.

flutter-dashboard · 2024-08-07T21:57:39Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #54293 at sha 4bb55da

jonahwilliams · 2024-08-08T17:59:53Z

Friendly ping @flar :)

flar · 2024-08-08T21:23:51Z

Sorry, I was still looking at why the goldens changed. I don't trust that.

flar · 2024-08-08T21:24:35Z

Is there any way to load up the changed goldens again?

chinmaygarde · 2024-08-08T22:44:09Z

Hmm, not that I know of. Perhaps you can create a revert PR (but not submit it) to show the reverse change to introspect.

…153132) flutter/engine@ef820aa...0520889 2024-08-08 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Detect animated WebP images (flutter/engine#54418) 2024-08-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 067c7cfcbc8c to ff0404c72fc5 (1 revision) (flutter/engine#54455) 2024-08-08 jonahwilliams@google.com [Impeller] move aiks text tests to DL. (flutter/engine#54293) 2024-08-08 skia-flutter-autoroll@skia.org Roll Skia from 0c6dd1e6ff8e to 4cff580721cf (20 revisions) (flutter/engine#54454) 2024-08-08 robert.ancell@canonical.com Add a precision to the fragment shader (flutter/engine#54109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#153132) flutter/engine@ef820aa...0520889 2024-08-08 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Detect animated WebP images (flutter/engine#54418) 2024-08-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 067c7cfcbc8c to ff0404c72fc5 (1 revision) (flutter/engine#54455) 2024-08-08 jonahwilliams@google.com [Impeller] move aiks text tests to DL. (flutter/engine#54293) 2024-08-08 skia-flutter-autoroll@skia.org Roll Skia from 0c6dd1e6ff8e to 4cff580721cf (20 revisions) (flutter/engine#54454) 2024-08-08 robert.ancell@canonical.com Add a precision to the fragment shader (flutter/engine#54109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[Impeller] move aiks text tests to DL.

85ffa59

github-actions bot added the e: impeller label Aug 1, 2024

jonahwilliams added 5 commits August 1, 2024 16:54

++

92c1bdd

++

ceb8bdd

stb fixes.

028d04d

++

f9fbf49

add bounds.

b091bfb

flutter-dashboard bot added the will affect goldens label Aug 4, 2024

++

8019b83

++

030afbe

++

397ca9b

jonahwilliams requested review from bdero and flar August 6, 2024 19:57

flar reviewed Aug 6, 2024

View reviewed changes

dont peephole on clipped bounds.

776dc12

jonahwilliams requested a review from flar August 7, 2024 00:14

Merge branch 'main' into convert_more_tests1232

4bb55da

chinmaygarde approved these changes Aug 8, 2024

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024

auto-submit bot merged commit 0a8de3d into flutter:main Aug 8, 2024
31 checks passed

jonahwilliams deleted the convert_more_tests1232 branch August 8, 2024 20:29

engine-flutter-autoroll mentioned this pull request Aug 8, 2024

Roll Flutter Engine from ef820aa74f7a to 0a8de3dd3285 (3 revisions) flutter/flutter#153130

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2024

0a8de3dd3 [Impeller] move aiks text tests to DL. (flutter/engine#54293)

744a1a3

engine-flutter-autoroll mentioned this pull request Aug 8, 2024

Roll Flutter Engine from ef820aa74f7a to 05208896830a (5 revisions) flutter/flutter#153132

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2024

0a8de3dd3 [Impeller] move aiks text tests to DL. (flutter/engine#54293)

f0e2621

[Impeller] move aiks text tests to DL. #54293

[Impeller] move aiks text tests to DL. #54293

Uh oh!

Conversation

jonahwilliams commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Aug 4, 2024

Uh oh!

flutter-dashboard bot commented Aug 6, 2024

Uh oh!

flutter-dashboard bot commented Aug 6, 2024

Uh oh!

jonahwilliams commented Aug 6, 2024

Uh oh!

flutter-dashboard bot commented Aug 6, 2024

Uh oh!

flar commented Aug 6, 2024

Uh oh!

flar Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Aug 6, 2024

Uh oh!

flutter-dashboard bot commented Aug 6, 2024

Uh oh!

jonahwilliams commented Aug 7, 2024

Uh oh!

flutter-dashboard bot commented Aug 7, 2024

Uh oh!

jonahwilliams commented Aug 8, 2024

Uh oh!

Uh oh!

flar commented Aug 8, 2024

Uh oh!

flar commented Aug 8, 2024

Uh oh!

chinmaygarde commented Aug 8, 2024

Uh oh!

Uh oh!

jonahwilliams commented Aug 1, 2024 •

edited

Loading