This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
iOS: Fix IOSSurfaceNoopTest #55621
Merged
Merged
iOS: Fix IOSSurfaceNoopTest #55621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were passing nullptr to the IOSSurfaceNoop constructor: https://github.com/flutter/engine/blob/de1762dbc5cc3483631c5e511a3496998ec6cf65/shell/platform/darwin/ios/ios_surface_noop.mm#L23-L24 which calls the IOSSurface constructor: https://github.com/flutter/engine/blob/de1762dbc5cc3483631c5e511a3496998ec6cf65/shell/platform/darwin/ios/ios_surface.mm#L55-L58 Which calls `FML_DCHECK(ios_context_)`, which really doesn't like it when `ios_context_` is null.
wat
|
jonahwilliams
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2024
…156174) flutter/engine@de1762d...20369c5 2024-10-03 chinmaygarde@google.com [Impeller] A text layout and shaping API for the standalone library. (flutter/engine#55598) 2024-10-03 matanlurey@users.noreply.github.com Refactor `et run` (and friends). (flutter/engine#55537) 2024-10-03 jason-simmons@users.noreply.github.com [Impeller] Do not cull in TextFrameDispatcher::drawDisplayList if the transform has perspective (flutter/engine#55602) 2024-10-03 chris@bracken.jp iOS: Fix IOSSurfaceNoopTest (flutter/engine#55621) 2024-10-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] one aiks context per app. (#55393)" (flutter/engine#55625) 2024-10-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YKvfbpZ38daiwJ7H0... to TnSpLq0S9XT2rHGl1... (flutter/engine#55622) 2024-10-03 jonahwilliams@google.com [Impeller] one aiks context per app. (flutter/engine#55393) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from YKvfbpZ38dai to TnSpLq0S9XT2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Previously, we were passing `nullptr` to the `IOSSurfaceNoop` constructor: https://github.com/flutter/engine/blob/56d060d501b5d6bf7d1bf547bdb2bb690e24ca73/shell/platform/darwin/ios/ios_surface_noop.mm#L23-L24 which calls the IOSSurface constructor: https://github.com/flutter/engine/blob/56d060d501b5d6bf7d1bf547bdb2bb690e24ca73/shell/platform/darwin/ios/ios_surface.mm#L55-L58 Which calls `FML_DCHECK(ios_context_)`, which really doesn't like it when `ios_context_` is null. I will later follow up with the next question of... "what exactly is going on with our CI here?", but this unbreaks my local dev testing workflow for the moment :) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were passing
nullptr
to theIOSSurfaceNoop
constructor:engine/shell/platform/darwin/ios/ios_surface_noop.mm
Lines 23 to 24 in de1762d
which calls the IOSSurface constructor:
engine/shell/platform/darwin/ios/ios_surface.mm
Lines 55 to 58 in de1762d
Which calls
FML_DCHECK(ios_context_)
, which really doesn't like it whenios_context_
is null.I will later follow up with the next question of... "what exactly is going on with our CI here?", but this unbreaks my local dev testing workflow for the moment :)
Answer to what exactly is going on with our CI here: flutter/flutter#156166
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.