Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Oct 3, 2024

Previously, we were passing nullptr to the IOSSurfaceNoop constructor:

IOSSurfaceNoop::IOSSurfaceNoop(std::shared_ptr<IOSContext> context)
: IOSSurface(std::move(context)) {}

which calls the IOSSurface constructor:

IOSSurface::IOSSurface(std::shared_ptr<IOSContext> ios_context)
: ios_context_(std::move(ios_context)) {
FML_DCHECK(ios_context_);
}

Which calls FML_DCHECK(ios_context_), which really doesn't like it when ios_context_ is null.

I will later follow up with the next question of... "what exactly is going on with our CI here?", but this unbreaks my local dev testing workflow for the moment :)

Answer to what exactly is going on with our CI here: flutter/flutter#156166

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Previously, we were passing nullptr to the IOSSurfaceNoop constructor:
https://github.com/flutter/engine/blob/de1762dbc5cc3483631c5e511a3496998ec6cf65/shell/platform/darwin/ios/ios_surface_noop.mm#L23-L24

which calls the IOSSurface constructor:
https://github.com/flutter/engine/blob/de1762dbc5cc3483631c5e511a3496998ec6cf65/shell/platform/darwin/ios/ios_surface.mm#L55-L58

Which calls `FML_DCHECK(ios_context_)`, which really doesn't like it when `ios_context_` is null.
@jmagman
Copy link
Member

jmagman commented Oct 3, 2024

wat

Test Case '-[IOSSurfaceNoopTest testCreateSurface]' passed (0.013 seconds).

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8735086402681946753/+/u/test:_Tests_for_ios_debug_unopt_sim/stdout

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2024
@auto-submit auto-submit bot merged commit d1947d3 into flutter:main Oct 3, 2024
29 checks passed
@cbracken cbracken deleted the fix-ios_surface_noop_test branch October 3, 2024 19:37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 3, 2024
…156174)

flutter/engine@de1762d...20369c5

2024-10-03 chinmaygarde@google.com [Impeller] A text layout and shaping API for the standalone library. (flutter/engine#55598)
2024-10-03 matanlurey@users.noreply.github.com Refactor `et run` (and friends). (flutter/engine#55537)
2024-10-03 jason-simmons@users.noreply.github.com [Impeller] Do not cull in TextFrameDispatcher::drawDisplayList if the transform has perspective (flutter/engine#55602)
2024-10-03 chris@bracken.jp iOS: Fix IOSSurfaceNoopTest (flutter/engine#55621)
2024-10-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] one aiks context per app. (#55393)" (flutter/engine#55625)
2024-10-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YKvfbpZ38daiwJ7H0... to TnSpLq0S9XT2rHGl1... (flutter/engine#55622)
2024-10-03 jonahwilliams@google.com [Impeller] one aiks context per app. (flutter/engine#55393)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from YKvfbpZ38dai to TnSpLq0S9XT2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
Previously, we were passing `nullptr` to the `IOSSurfaceNoop` constructor:
https://github.com/flutter/engine/blob/56d060d501b5d6bf7d1bf547bdb2bb690e24ca73/shell/platform/darwin/ios/ios_surface_noop.mm#L23-L24

which calls the IOSSurface constructor:
https://github.com/flutter/engine/blob/56d060d501b5d6bf7d1bf547bdb2bb690e24ca73/shell/platform/darwin/ios/ios_surface.mm#L55-L58

Which calls `FML_DCHECK(ios_context_)`, which really doesn't like it when `ios_context_` is null.

I will later follow up with the next question of... "what exactly is going on with our CI here?", but this unbreaks my local dev testing workflow for the moment :)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants