Skip to content

Error check before hot reload will cause reloads to fail if a clean app is in a bigger project with separate failures #3168

@DaveShuckerow

Description

@DaveShuckerow
  1. Introduce an error to test code (say a line that has no semicolon).
  2. Run the app
  3. Reloading the app fails.

The lines below cause this to happen:

if (hasErrors(app.getProject(), app.getModule(), editor.getDocument())) {
handlingSave.set(false);
showAnalysisNotification("Reload not performed", "Analysis issues found", true);
return;
}

I'm looking into removing those and letting the flutter daemon tell us if it's safe to reload the app. The parent to this issue is flutter/flutter#27618

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions