Skip to content

♻️ Add back the device name with the running tab #7948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jwren merged 3 commits into from
Apr 11, 2025
Merged

♻️ Add back the device name with the running tab #7948

jwren merged 3 commits into from
Apr 11, 2025

Conversation

@AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Feb 21, 2025 •
edited
Loading

Recovers the ability of #6774.
Fixes #7605
Fixes #7539

myDisplayName no longer exists in the com.intellij.execution.ui.RunContentDescriptor, it has been replaced by a MutableReactiveProperty myDisplayNameView since 2024 builds.

2024+ myDisplayNameView
2023 myDisplayName

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@AlexV525 AlexV525 self-assigned this Feb 21, 2025
@AlexV525 AlexV525 force-pushed the fix/launch-descriptor-with-device-name branch 3 times, most recently from 5f69c50 to 6d21c82 Compare February 21, 2025 03:48
@AlexV525 AlexV525 force-pushed the fix/launch-descriptor-with-device-name branch from 6d21c82 to 4096930 Compare February 21, 2025 03:51
@AlexV525 AlexV525 marked this pull request as ready for review February 21, 2025 04:01
@AlexV525 AlexV525 changed the title ♻️ Refactored from myDisplayName to myDisplayNameView to add back the device name with the running tab ♻️ Add back the device name with the running tab Feb 21, 2025
@AlexV525 AlexV525 requested a review from jwren March 15, 2025 11:29
@AlexV525
Copy link
Member Author

AlexV525 commented Apr 8, 2025

@jwren

@AlexV525 AlexV525 requested review from elliette, helin24 and pq April 9, 2025 05:39
pq
pq reviewed Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @jwren or @helin24 who have more current context but as scary as this introspection is, it seems reasonable (if unfortunate). The guards seem to mitigate risk too.

pq
pq reviewed Apr 9, 2025
View reviewed changes
@jwren
Copy link
Member

jwren commented Apr 10, 2025

Sorry for the delay. The Flutter IJ plugin doesn't have tests for changes like this which is unfortunately. @AlexV525, I have not had a chance to test / validate this change myself, but would be very happy to have it land. If you have cycles, do add a few notes point out the history here in the code, and rebase to recent changes on master. Regardless though of your time, this is a good change and I'll make sure it lands for either M85.1 or M85.2 if it works as you describe.

@AlexV525
Copy link
Member Author

AlexV525 commented Apr 11, 2025

If you have cycles, do add a few notes point out the history here in the code, and rebase to recent changes on master.

I've added a few comments that indicate what the code is trying to do and why, also with src links to the InteliiJ Platform SDK.

The branch is also updated.

@jwren jwren merged commit a6abe92 into flutter:master Apr 11, 2025
9 checks passed
@AlexV525 AlexV525 deleted the fix/launch-descriptor-with-device-name branch April 11, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pq pq pq left review comments

@jwren jwren jwren approved these changes

@helin24 helin24 Awaiting requested review from helin24

@elliette elliette Awaiting requested review from elliette

Assignees

@AlexV525 AlexV525

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@AlexV525 @jwren @pq