Thanks for the digging @DanTup!

DevTools is also potentially spawned in the Flutter Plugin here:

flutter-intellij/flutter-idea/src/io/flutter/run/daemon/DevToolsService.java

Lines 168 to 182 in 944aa02

    
             final String dartPluginUri = DartDevToolsService.getInstance(project).getDevToolsHostAndPort(); 
        
             if (dartPluginUri != null) { 
        
               String[] parts = dartPluginUri.split(":"); 
        
               String host = parts[0]; 
        
               Integer port = Integer.parseInt(parts[1]); 
        
               if (host != null && port != null) { 
        
                 devToolsFutureRef.get().complete(new DevToolsInstance(host, port)); 
        
                 return; 
        
               } 
        
             } 
        
             setUpWithDart(createCommand(DartSdk.getDartSdk(project).getHomePath(), 
        
                                         DartSdk.getDartSdk(project).getHomePath() + File.separatorChar + "bin" + File.separatorChar + "dart", 
        
                                         ImmutableList.of("devtools", "--machine"))); 
        
           }

If dartPluginUri returns null (as it could if DevTools is not fully up yet), line 179 will call setUpWithDart and create another instance. (In fact, forcing this to happen by commenting out the check above is the only way I could reproduce the spinner; but then I could!)

What's interesting is that this fallback to create a DevTools instance here may be entirely unnecessary and was only in place to support a time when the Dart plugin wasn't creating one itself (or unreliably). As that time was long ago, at least since JetBrains/intellij-plugins@9182286, we can probably safely skip this fallback and I'm exploring what that might mean.

Whether or not we can do away with that instance creation, I'm also wondering about getting the DevTools instance information properly cached for the views that need to access it. In particular, what I don't know is whether we need to put a wait condition around DartDevToolsService.getInstance(project).getDevToolsHostAndPort() to ensure that the host and port get properly set in the future for later retrieval. Specifically this needs to get called at some point before anyone can get details.

flutter-intellij/flutter-idea/src/io/flutter/run/daemon/DevToolsService.java

Line 174 in 944aa02

devToolsFutureRef.get().complete(new DevToolsInstance(host, port));

That said, the containing method startServer() does get called a few times so it's possible that the race is rarely (if ever) lost in practice and that by the time, for example the property editor, needs the port and host the last call to startServer() has set it, even if the first had not.

(fyi @elliette who may have more insight as I'm just getting my head wrapped around all of this.)

Another thing that could be confusing folks debugging is whether they've got a LOCAL_DEVTOOLS_DIR registry entry set. If they do, we have another path to a second DevTools instance:

flutter-intellij/flutter-idea/src/io/flutter/run/daemon/DevToolsService.java

Lines 140 to 165 in 944aa02

    
           final String localDevToolsDir = Registry.stringValue(LOCAL_DEVTOOLS_DIR); 
        
           if (!localDevToolsDir.isEmpty()) { 
        
             // This is only for development to check integration with a locally run DevTools server. 
        
             // To enable, follow the instructions in: 
        
             // https://github.com/flutter/flutter-intellij/blob/master/CONTRIBUTING.md#developing-with-local-devtools 
        
             final DtdUtils dtdUtils = new DtdUtils(); 
        
             try { 
        
               final DartToolingDaemonService dtdService = dtdUtils.readyDtdService(project).get(); 
        
               final String dtdUri = dtdService.getUri(); 
        
               final List<String> args = new ArrayList<>(); 
        
               args.add("serve"); 
        
               args.add("--machine"); 
        
               args.add("--dtd-uri=" + dtdUri); 
        
               final String localDevToolsArgs = Registry.stringValue(LOCAL_DEVTOOLS_ARGS); 
        
               if (!localDevToolsArgs.isEmpty()) { 
        
                 args.addAll(Arrays.stream(localDevToolsArgs.split(" ")).toList()); 
        
               } 
        
               setUpInDevMode(createCommand(localDevToolsDir, "dt", args)); 
        
             } 
        
             catch (InterruptedException | java.util.concurrent.ExecutionException e) { 
        
               throw new RuntimeException(e); 
        
             } 
        
             return; 
        
           }

There's also the (slim) chance folks will get a second instance here:

flutter-intellij/flutter-idea/src/io/flutter/run/daemon/DevToolsService.java

Lines 132 to 138 in 944aa02

    
           // This condition means we can use `dart devtools` to start. 
        
           final WorkspaceCache workspaceCache = WorkspaceCache.getInstance(project); 
        
           if (workspaceCache.isBazel()) { 
        
             // This is only for internal usages. 
        
             setUpWithDart(createCommand(workspaceCache.get().getRoot().getPath(), workspaceCache.get().getDevToolsScript(), 
        
                                         ImmutableList.of("--machine"))); 
        
           }

The comment suggests this is internal only but I'm not sure if that's totally right as there are external folks using Bazel workspaces. (I think?)

	final String dartPluginUri = DartDevToolsService.getInstance(project).getDevToolsHostAndPort();
	if (dartPluginUri != null) {
	String[] parts = dartPluginUri.split(":");
	String host = parts[0];
	Integer port = Integer.parseInt(parts[1]);
	if (host != null && port != null) {
	devToolsFutureRef.get().complete(new DevToolsInstance(host, port));
	return;
	}
	}

	setUpWithDart(createCommand(DartSdk.getDartSdk(project).getHomePath(),
	DartSdk.getDartSdk(project).getHomePath() + File.separatorChar + "bin" + File.separatorChar + "dart",
	ImmutableList.of("devtools", "--machine")));
	}

	final String localDevToolsDir = Registry.stringValue(LOCAL_DEVTOOLS_DIR);
	if (!localDevToolsDir.isEmpty()) {
	// This is only for development to check integration with a locally run DevTools server.
	// To enable, follow the instructions in:
	// https://github.com/flutter/flutter-intellij/blob/master/CONTRIBUTING.md#developing-with-local-devtools
	final DtdUtils dtdUtils = new DtdUtils();
	try {
	final DartToolingDaemonService dtdService = dtdUtils.readyDtdService(project).get();
	final String dtdUri = dtdService.getUri();

	final List<String> args = new ArrayList<>();
	args.add("serve");
	args.add("--machine");
	args.add("--dtd-uri=" + dtdUri);
	final String localDevToolsArgs = Registry.stringValue(LOCAL_DEVTOOLS_ARGS);
	if (!localDevToolsArgs.isEmpty()) {
	args.addAll(Arrays.stream(localDevToolsArgs.split(" ")).toList());
	}

	setUpInDevMode(createCommand(localDevToolsDir, "dt", args));
	}
	catch (InterruptedException \| java.util.concurrent.ExecutionException e) {
	throw new RuntimeException(e);
	}
	return;
	}

	// This condition means we can use `dart devtools` to start.
	final WorkspaceCache workspaceCache = WorkspaceCache.getInstance(project);
	if (workspaceCache.isBazel()) {
	// This is only for internal usages.
	setUpWithDart(createCommand(workspaceCache.get().getRoot().getPath(), workspaceCache.get().getDevToolsScript(),
	ImmutableList.of("--machine")));
	}

Infinite spinner while trying to load property editor #8144

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions