Avoid NPE if addPerfListener is called out of order with creating perfManager.getCurrentStats() #3182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
commented
Feb 11, 2019
|
Hold off on reviewing. I think I found one more edge case. |
perfManager.getCurrentStats() Add removePerfListener call so we don't have to guess about lifecycles for perf listeners.
|
Implemented a more robust fix. Now listeners are disposed when the view is destroyed but not when the app is just rerun. |
devoncarew
approved these changes
Feb 11, 2019
| if (currentStats != null) { | ||
| currentStats.dispose(); | ||
| currentStats = null; | ||
| listeners.clear(); |
There was a problem hiding this comment.
Should we instead call removePerfListener for each listener?
There was a problem hiding this comment.
I don't think we need to as the stats object the listeners are added to is disposed a couple lines earlier.
This was referenced Mar 27, 2019
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix
#3173