Skip to content

Conversation

devoncarew
Copy link
Member

  • update the product matrix

@stevemessick, I noticed that we were shipping nearly the same version ranges for IntelliJ 2018.2.5 and AS 3.3.1 (182.5107.7 - 182.*). I don't know that the jetbrains plugin server would know which version to distribute, and assume that we no longer need to support IntelliJ 2018.2. I assume this change is correct, but would like your eyes on it.

We may want to add some automation to the bots here - perhaps a dart script which will parse this file, and fail with error if there are any overlapping ranges, or unintentional gaps in ranges.

@stevemessick
Copy link
Member

I don't have 2018.2.5 installed to easily check that it is working. I'll get it as soon as I can. All the others work, but that's a good point that this one needs to be verified. I had a lot of trouble getting the 2018.3 builds figured out, so I'm pretty sure I don't fully understand how the Jetbrains server decides which file to provide -- meaning that automatic checking should wait until we have better understanding. BTW I'm thinking about adding beta and canary channels to our plugin distro so we can just side-step the whole version range issue for Android Studio.

@stevemessick
Copy link
Member

BTW the redness is caused by a bug in the travis script. I'll look at it later.

@devoncarew
Copy link
Member Author

I don't have 2018.2.5 installed to easily check that it is working.

I think we can drop support for IntelliJ 2018.2 - stable is at 2018.3. I assume we just need support for this platform version range for AS 3.3.1 / AS 3.3.

Copy link
Member

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I forgot to click Approve earlier. Sorry 'bout that.

@stevemessick stevemessick mentioned this pull request Feb 19, 2019
@devoncarew devoncarew merged commit 0ea8ef5 into flutter:master Feb 20, 2019
alexander-doroshko pushed a commit to alexander-doroshko/flutter-intellij that referenced this pull request Jan 24, 2020
* update the product matrix

* update .travis.yml

* update resources/META-INF/plugin.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants