read sample index from flutter_tool call #3379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevemessick
approved these changes
Apr 18, 2019
| // // ignore | ||
| //} | ||
| // | ||
| //return getElement() + suffix; |
There was a problem hiding this comment.
I'm assuming you want to keep all the above in case it is useful solving the TODOs. If you just forgot about it, then here's a reminder to delete it. :)
There was a problem hiding this comment.
Intentional. But thanks!
| catch (IOException e) { | ||
| LOG.warn(e); | ||
| // On IOException, short circuit checking again. | ||
| flutterSamples = Collections.emptyList(); |
There was a problem hiding this comment.
If the network is unreliable, will the IDE have to be restarted to reset flutterSamples?
There was a problem hiding this comment.
I'm going to look into this some more. There are a few wrinkles.
Thanks!
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3303 .
/cc @stevemessick