Fix MainFileTest #3388
Merged
Fix MainFileTest #3388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes |
|
Neat! Is there any way we could make sure we're only ignoring the desired runtime exception? Or maybe that's not worth it? |
|
It is a private class. I used it's super class.
…On Fri, Apr 19, 2019, 3:07 PM Phil Quitslund ***@***.***> wrote:
Neat! Is there any way we could make sure we're only ignoring the desired
runtime exception? Or maybe that's not worth it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3388 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACA7VDPDIC4VNOKOSWH45LLPRI7B5ANCNFSM4HHIBMFQ>
.
|
|
Got it. If you think this might miss genuine failures, you could do something to check the class name but that's totally up to you. Thanks for following up! |
|
Thanks for the tip. I'll do that in a follow-up PR. |
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pq
This is a hack. But the test runs. The failure had nothing to do with any test code we have control over. I think it is due to something that was added to the Kotlin test framework, but I don't know for sure.