more work to support running Flutter web apps #3389
Conversation
| @Nullable FlutterDevice device = DeviceService.getInstance(project).getSelectedDevice(); | ||
|
|
||
| boolean isFlutterWeb = false; | ||
| final String filePath = ((SdkRunConfig)runConfig).getFields().getFilePath(); |
There was a problem hiding this comment.
Do you need to normalize here to ensure windows is supported, or has that already happened in getFilePath?
There was a problem hiding this comment.
This just restructures the code on the left to remove a level of nesting - it's fundamentally the same as the previous code.
|
Some updates:
With the latest updates, the inspector now works. |
| catch (UnsupportedEncodingException ignored) { | ||
| } | ||
|
|
||
| BrowserLauncher.getInstance().browse( |
There was a problem hiding this comment.
Do you want browse() to be called even if there is a caught exception in the try block above? Reading the code here makes it look like browse() here is supposed to be inside the try-block.
There was a problem hiding this comment.
good point; this shouldn't happen - the UTF-8 encoding should be available - but I'll move the browser call up to within the try block in any case
| } | ||
| catch (Exception e) { | ||
| // Nothing to do if the service can't be acquired. | ||
| } |
There was a problem hiding this comment.
e -> ignored for IntelliJ inspections.
This reverts commit ff4e5ff.
* clean up to our flutter web support * remove printlns * fix inspector npes * review comments
3 participants
Various work in support of #3293:
"Build: Running build completed, took 191ms") was erroneously hyperlinked to in the run consoledaemon.logevent, to better support showing output from running flutter web appsFlutterCommand.FLUTTER_WEB_RUNcommandThings that are not yet supported:
Both of the above issues will need to be resolved for flutter web support (not necessarily in this PR).