Skip to content

Conversation

devoncarew
Copy link
Member

  • provision webdev for flutter_web projects
  • fix P0: IntelliJ can create, launch, connect and inspect a FlutterWeb app (a webdev based workflow) #3293
  • add a WebDevManager manager class to provision webdev
  • on startup for flutter web projects, check if there's a flutter sdk, and if so provision webdev
  • allow the user to pass additional args into webdev daemon in the launch configs (similar to what we do for flutter run)
  • show webdev (and devtools) installation progress in IntelliJ (instead of using the Messages tool window)

@devoncarew devoncarew requested a review from jwren April 24, 2019 22:10
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return ServiceManager.getService(project, WebDevManager.class);
}

private final Project project;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NotNull can be put on this field.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@devoncarew devoncarew merged commit 40b60be into flutter:master Apr 24, 2019
stevemessick pushed a commit that referenced this pull request Apr 26, 2019
* provision webdev for flutter_web projects

* ws

* review comments
alexander-doroshko pushed a commit to alexander-doroshko/flutter-intellij that referenced this pull request Jan 24, 2020
* provision webdev for flutter_web projects

* ws

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P0: IntelliJ can create, launch, connect and inspect a FlutterWeb app (a webdev based workflow)

3 participants