Skip to content

Conversation

@devoncarew
Copy link
Contributor

@devoncarew devoncarew commented Mar 30, 2020

Instead of deciding to summarize errors subsequent to the first error after a reload, we instead summarize errors subsequent to the first error after a frame event. Those errors are more likely to be errors (overflow, ...) triggered by the first error.

From the flutter error sample app, navigating to the material error, then the overflow error, you can see now that the overflow triggered by the material error is summarized, but the later overflow from the overflow page is not.

Screen Shot 2020-03-29 at 10 06 33 PM

...

Screen Shot 2020-03-29 at 10 06 49 PM

Copy link
Member

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@devoncarew devoncarew merged commit 65f0fb4 into flutter:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structure error missing parts when displayed in IntelliJ

3 participants