Skip to content

Ignore disposed project in FlutterAppManager #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Ignore disposed project in FlutterAppManager #6554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions flutter-idea/src/io/flutter/run/FlutterAppManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public static FlutterAppManager getInstance(@NotNull Project project) {
private FlutterAppManager(@NotNull Project project) {
this.project = project;

// TODO This object shoud have a different disposable parent to enable dynamic plugin loading.
Disposer.register(project, this);

task = JobScheduler.getScheduler().scheduleWithFixedDelay(
Expand Down Expand Up @@ -119,6 +120,9 @@ private void updateActiveApp() {

@Nullable
private RunContentManager getRunContentManager() {
if (project.isDisposed()) {
return null;
}
// Creating a RunContentManager causes a blank window to appear, so don't create it here.
// See https://github.com/flutter/flutter-intellij/issues/4217
if (ServiceManager.getServiceIfCreated(project, RunContentManager.class) == null) {
Expand Down