Skip to content

Allow making the plugin from multiple platforms #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2023
Merged

Allow making the plugin from multiple platforms #6730

merged 6 commits into from
May 6, 2023

Conversation

@AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Apr 27, 2023 •
edited
Loading

...especially for Windows Native (without WSL).

Resolves #6052 #6640 #6733

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@AlexV525 AlexV525 linked an issue Apr 27, 2023 that may be closed by this pull request
[Infra] Unable to build the plugin from Windows #6640
Closed
@AlexV525 AlexV525 mentioned this pull request Apr 28, 2023
Closed
AlexV525
AlexV525 commented Apr 28, 2023
View reviewed changes
@AlexV525 AlexV525 marked this pull request as ready for review April 28, 2023 03:36
stevemessick
stevemessick approved these changes May 2, 2023
View reviewed changes
@AlexV525
Copy link
Member Author

AlexV525 commented May 4, 2023 •
edited
Loading

I just experienced a full tour of the building and running the plugin on Windows. There are a couple of places that need to be updated in the contributing doc.

Filed #6740.

@AlexV525 AlexV525 marked this pull request as draft May 4, 2023 04:48
@AlexV525 AlexV525 marked this pull request as ready for review May 4, 2023 11:14
@AlexV525 AlexV525 linked an issue May 5, 2023 that may be closed by this pull request
[Infra] Failed to make the plugin on Windows #6733
Closed
@AlexV525 AlexV525 requested a review from stevemessick May 5, 2023 04:31
stevemessick
stevemessick approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@AlexV525 AlexV525 merged commit 33e48fc into flutter:master May 6, 2023
@AlexV525 AlexV525 deleted the remove-platform-based-command branch May 6, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevemessick stevemessick stevemessick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Infra] Failed to make the plugin on Windows [Infra] Unable to build the plugin from Windows bin/plugin make fails on Windows

2 participants

@AlexV525 @stevemessick