Add a flutter pub add action #7924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwren
approved these changes
Feb 4, 2025
Member
jwren
left a comment
jwren
left a comment
There was a problem hiding this comment.
LGTM
Revert out the gradle.properties changes. Also, you'll have to run ./bin/plugin generate to get the github presubmit action to pass.
jakemac53
commented
Feb 4, 2025
Contributor
Author
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening in case we are interesting in actually upstreaming this - I mostly just did it to get familiar with how actions are set up and plumbed through.
Using the action opens a dialog like this:
It does do some validation that a non-empty package name was input, but that is it today:
And it does ensure you actually clicked "OK" before actually running any commands.