Skip to content

ignore gradle.properties and .idea/misc.xml to reduce friction creating prs #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

ignore gradle.properties and .idea/misc.xml to reduce friction creating prs #7928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adc5ed6
ignore gradle.properties and .idea/misc.xml to reduce friction creati…
jakemac53 Feb 4, 2025
853bdc0
add newline
jakemac53 Feb 4, 2025
a1e7913
be resilient to non-existent gradle.properties files
jakemac53 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ lib/kotlin*
gradle
gradlew
gradlew.bat
# User specific configuration based on current Intellij SDKs.
gradle.properties
.idea/misc.xml
14 changes: 0 additions & 14 deletions .idea/misc.xml
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions gradle.properties
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions tool/plugin/lib/runner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ org.gradle.parallel=true
org.gradle.jvmargs=-Xms1024m -Xmx4048m
''';
final propertiesFile = File("$rootPath/gradle.properties");
final source = propertiesFile.readAsStringSync();
final source = propertiesFile.existsSync()
? propertiesFile.readAsStringSync()
: null;
propertiesFile.writeAsStringSync(contents);
int result;
// Using the Gradle daemon causes a strange problem.
Expand All @@ -99,7 +101,7 @@ org.gradle.jvmargs=-Xms1024m -Xmx4048m
}
}
} finally {
propertiesFile.writeAsStringSync(source);
if (source != null) propertiesFile.writeAsStringSync(source);
}
return result;
}
Expand Down